Update proposer boost score and spec tests #10665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @terencechain, I noticed that you've started working on this change. |
Ack. Thank you! :) |
terencechain
changed the title
terencechain
added
Ready For Review
rauljordan
previously approved these changes
May 23, 2022
rauljordan
previously approved these changes
May 23, 2022
potuz
previously approved these changes
May 23, 2022
potuz
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by: ethereum/consensus-specs#2888
Rationale: https://notes.ethereum.org/@casparschwa/H1T0k7b85
I bundled spec test update
v1.2.0-rc.1in the same PR, we need to parsemainnet.yamlfor 40% and we can't do it in another PR because we need to fix the proposed boost score tests. Chicken and egg problem so easier to do both together