Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standby mode metric added - new pull request with unit tests #191

Merged
merged 11 commits into from
Apr 20, 2020
Merged

Standby mode metric added - new pull request with unit tests #191

merged 11 commits into from
Apr 20, 2020

Conversation

rmontenegroo
Copy link
Contributor

Hi there! Making a new pull request. This time with those unit tests you asked. I hope it helps.

@codecov-io
Copy link

codecov-io commented Apr 16, 2020

Codecov Report

Merging #191 into master will decrease coverage by 0.13%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   93.77%   93.63%   -0.14%     
==========================================
  Files           4        4              
  Lines         546      550       +4     
==========================================
+ Hits          512      515       +3     
- Misses         34       35       +1     
Impacted Files Coverage Δ
vmware_exporter/vmware_exporter.py 92.85% <66.66%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f911ad0...0c9ee05. Read the comment docs.

Copy link
Owner

@pryorda pryorda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pryorda pryorda merged commit 529eb8f into pryorda:master Apr 20, 2020
@pryorda
Copy link
Owner

pryorda commented Apr 20, 2020

Thanks again for your contribution on the last two PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants