creality.ini: start_gcode fix #4854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rtyr: would you please take a look at this? |
|
It looks ok to me, thanks. |
pmjdebruijn
changed the title
|
thanks, it will be part of the upcoming PrusaSlicer 2.3.0-alpha1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes start_gcode/end_gcode from the common section, it seems to me that these gcodes are highly printer specific, thus should probably be defined on the printer, rendering these gcodes in the common section more confusing than anything else.
Also, on the second prime line, a lot of filament is being extruded, double that of the first prime line, this seems like a mistake to me, maybe because relative mode was used in the past? So this changes E30 to E15 like on the first prime line.