Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ctrl+Shift+I to open a new instance instead of Ctrl+I #4734

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

wavexx
Copy link
Contributor

@wavexx wavexx commented Sep 11, 2020

"Open new instance" overrides the "import" shortcut.

Use Ctrl+Shift+I for new instance, which is definitely less important
than importing new models.

Also document the shortcut in the Keyboard shortcuts dialog.

Fixes #4711

@wavexx wavexx force-pushed the fix_new_instance_shortcut branch from 02b3a72 to 970fb75 Compare October 12, 2020 16:19
"Open new instance" overrider the "import" shortcut.

Use Ctrl+Shift+I for new instance, which is definitely less important
than importing new models.

Also document the shortcut in the Keyboard shortcuts dialog.

Fixes prusa3d#4711
@wavexx wavexx force-pushed the fix_new_instance_shortcut branch from 970fb75 to 1fd5493 Compare October 14, 2020 18:51
@nordurljosahvida
Copy link
Contributor

is this good be merged?

@bubnikv
Copy link
Collaborator

bubnikv commented Dec 7, 2020

Thanks.

@stefanct
Copy link

stefanct commented Dec 7, 2020

I still think that it should be Ctrl+n for new instances as per about every UI guideline in the world... as outlined I outlined in #4711.

Some pointers why this is important (well, relatively in this hot stinking mess of reality :)

@nordurljosahvida
Copy link
Contributor

thanks for merging this bubnikv. I do agree with you stefanct in a way but also keep in mind we're already using ctrl+n for scrapping the current plate and starting with a new project, so I'm not sure what would be the best use of this shortcut.

@stefanct
Copy link

stefanct commented Dec 8, 2020

Well, yes of course changing something in the UI will always upset people. https://xkcd.com/1172/ and all that. :) It's still the right thing to do IMHO. If you compare the File menu to any other application that has similar entries, you would never expect "New project" to clear the current one. It's like a browser that opens the default page in the current tab when pressing ctrl+t "forgetting" what was currently open.

There is also a very natural way to do what ctrl+n currently does: ctrl+a, del (there is a small difference regarding saving the project here but changing the new project entry would actually improve things in this regard too IMHO).

So to summarize, yes, this will break the habits of some existing users but would help new ones - and I think even the majority of existing users would profit from it.

@bubnikv
Copy link
Collaborator

bubnikv commented Dec 8, 2020 via email

@nordurljosahvida
Copy link
Contributor

amazing

@wavexx wavexx deleted the fix_new_instance_shortcut branch December 13, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+I shortcut overridden
4 participants