-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ctrl+Shift+I to open a new instance instead of Ctrl+I #4734
Conversation
02b3a72
to
970fb75
Compare
"Open new instance" overrider the "import" shortcut. Use Ctrl+Shift+I for new instance, which is definitely less important than importing new models. Also document the shortcut in the Keyboard shortcuts dialog. Fixes prusa3d#4711
970fb75
to
1fd5493
Compare
is this good be merged? |
Thanks. |
I still think that it should be Ctrl+n for new instances as per about every UI guideline in the world... as outlined I outlined in #4711. Some pointers why this is important (well, relatively in this hot stinking mess of reality :)
|
thanks for merging this bubnikv. I do agree with you stefanct in a way but also keep in mind we're already using ctrl+n for scrapping the current plate and starting with a new project, so I'm not sure what would be the best use of this shortcut. |
Well, yes of course changing something in the UI will always upset people. https://xkcd.com/1172/ and all that. :) It's still the right thing to do IMHO. If you compare the File menu to any other application that has similar entries, you would never expect "New project" to clear the current one. It's like a browser that opens the default page in the current tab when pressing ctrl+t "forgetting" what was currently open. There is also a very natural way to do what ctrl+n currently does: ctrl+a, del (there is a small difference regarding saving the project here but changing the new project entry would actually improve things in this regard too IMHO). So to summarize, yes, this will break the habits of some existing users but would help new ones - and I think even the majority of existing users would profit from it. |
It's like this one:
Prusa3D by Josef Prusa on Twitter: "POLL: PrusaSlicer Eject button. In the
new design, the button appears in a notification after the G-code export.
In the old design, the button appears on the right side next to the Export
button. We changed it partly because it was easy to hit that button by
mistake. https://t.co/pgF7rVKCRk" / Twitter
<https://twitter.com/Prusa3D/status/1335972556906618880>
út 8. 12. 2020 v 13:09 odesílatel Stefan Tauner <[email protected]>
napsal:
… Well, yes of course changing something in the UI will always upset people.
https://xkcd.com/1172/ and all that. :) It's still the right thing to do
IMHO. If you compare the *File* menu to any other application that has
similar entries, you would never expect "New project" to clear the current
one. It's like a browser that opens the default page *in the current tab*
when pressing ctrl+t "forgetting" what was currently open.
There is also a very natural way to do what ctrl+n currently does: ctrl+a,
del (there is a small difference regarding saving the project here but
changing the new project entry would actually improve things in this regard
too IMHO).
So to summarize, yes, this will break the habits of some existing users
but would help new ones - and I think even the majority of existing users
would profit from it.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4734 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMPSI3BLS7XY5PAK6EKD53STYJOJANCNFSM4RH3EIGQ>
.
|
amazing |
"Open new instance" overrides the "import" shortcut.
Use Ctrl+Shift+I for new instance, which is definitely less important
than importing new models.
Also document the shortcut in the Keyboard shortcuts dialog.
Fixes #4711