Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4062 Conversion of empty layer error to warning. #4283

Closed
wants to merge 1 commit into from

Conversation

espr14
Copy link
Contributor

@espr14 espr14 commented May 21, 2020

This is a proposal only to solve #4062.
This enables printing with empty layers. Sometimes they are intentional. No text was altered but should be changed, probably (+translations).

@espr14 espr14 changed the title Conversion of empty layer error to warning. #4062 Conversion of empty layer error to warning. May 21, 2020
@lukasmatena
Copy link
Collaborator

I'm afraid it is not this simple. libslic3r module should not depend on wxWidgets.

@espr14
Copy link
Contributor Author

espr14 commented May 26, 2020

OK. You can close the PR if you want.

@lukasmatena
Copy link
Collaborator

I'm sorry, but I will really close it. I admit that the idea of triggering overridable warnings from the backend has its use cases (such as this one), but it should not be done this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants