Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gentoo/NixOS compile failure #13080

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Rose-David
Copy link
Contributor

@Rose-David Rose-David commented Jul 12, 2024

Fixes a compile error on Gentoo Linux and NixOS.
Resolves #12884 and enables nixpkgs PR #325590 so that NixOS can update its repo to 2.8.0.

Code thanks to @mogorman

@Rose-David
Copy link
Contributor Author

According to @amatulic, this also resolves a compile error on Windows (#13037)

@Rose-David Rose-David changed the title Fix Gentoo/NixOS compile failure Fix Gentoo/NixOS/Windows compile failure Aug 1, 2024
@amatulic
Copy link

amatulic commented Aug 1, 2024

According to @amatulic, this also resolves a compile error on Windows (#13037)

Well, it might be related, but I doubt it. I mistakenly assumed this PR had already been merged when I noticed by coincidence that I was able to compile under Windows after the commits were made here. In any case, I can no longer reproduce #13037.

@Rose-David Rose-David changed the title Fix Gentoo/NixOS/Windows compile failure Fix Gentoo/NixOS compile failure Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.8.0 issues with building
2 participants