Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output filename generation based on variables broken #615

Closed
rongith opened this issue Dec 9, 2017 · 6 comments
Closed

Output filename generation based on variables broken #615

rongith opened this issue Dec 9, 2017 · 6 comments

Comments

@rongith
Copy link
Contributor

rongith commented Dec 9, 2017

Version

1.38.3

Operating system type + version

Windows 10 64bits

Behavior

Output filename format, in my case: [input_filename_base]-[P][print_preset]-[F][filament_preset]-[P][printer_preset]-[version]-[timestamp].gcode
Don't give a proper filename anymore.

@bubnikv
Copy link
Collaborator

bubnikv commented Dec 9, 2017

Slic3r 1.38.4 will emit an error report, that a variable named P does not exist. (that is for the [P] sequence).
I know the old Slic3r just ignored the non-existent variables, and you used this behavior. The new Slic3r will report it as an error.

@rongith
Copy link
Contributor Author

rongith commented Dec 11, 2017

The following output format filename doen't work too:
[input_filename_base]-(P)[print_preset]-(F)[filament_preset]-(P)[printer_preset]-[version]-[timestamp].gcode
Per exemple 1.37.2 gives:
Rectangle-250x210 - Defaut-(P)0.20-020pc-vmax-(F)Prusa PET-(P)PMK2 - Echelle-R0.8-1.37.2-prusa3d-win64-20171211-014804.gcode
1.38.3 gives:
Rectangle-250x210 - Defaut-(P).gcode

@bubnikv
Copy link
Collaborator

bubnikv commented Dec 11, 2017

I have uploaded a continuous build, which has the placeholder parser error reporting significantly improved. Would you please test with that? I just tested with your new template
[input_filename_base]-(P)[print_preset]-(F)[filament_preset]-(P)[printer_preset]-[version]-[timestamp].gcode
and it seem to work, it produces
20mmbox-(P)0.15mm OPTIMAL-(F)ColorFabb HT 1.75mm-(P)Original Prusa i3 MK2 MultiMaterial-1-20171211-092405.gcode

Slic3r-1.38.3.21-prusa3d-win64-full-gae5863f-201712102228.zip

@bubnikv
Copy link
Collaborator

bubnikv commented Dec 11, 2017

I found a bug in the "version" variable. I will post another continuous build soon.

@bubnikv
Copy link
Collaborator

bubnikv commented Dec 11, 2017

Here is an updated build.

Slic3r-1.38.3.22-prusa3d-win64-full-g1938828-201712110832.zip

This is the error message you receive from this build on your original template:
image

It is not ideal as the ^ arrow should point to the variable, but due to variable width font it does not. I shall fix that as well.

@rongith
Copy link
Contributor Author

rongith commented Dec 11, 2017

Nice!
I got now Rectangle-250x210 - Defaut-(P)0.20-020pc-vmax-(F)Prusa PET-(P)PMK2 - Echelle-R0.8-1.38.3.22-prusa3d-win64-20171211-141837.gcode

@rongith rongith closed this as completed Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants