Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux][GTK3] Dropdowns in quick settings are cut vertically with some themes #5505

Closed
jeanblanchard opened this issue Dec 18, 2020 · 9 comments

Comments

@jeanblanchard
Copy link

Version

Version 2.3.0-rc1+linux-x64-GTK3 (but this is not new to this version)

Operating system type + version

  • Linux (Solus 4.1)
  • KDE Plasma 5.20.3
  • GTK 3.24.24
  • GTK Theme: Breeze

Behavior

The text in the print settings, filament and printer dropdowns, in the main settings panel (the ones on the "Panel" tab) is cut vertically, with some GTK3 themes (notably all Breeze-based themes)

The "Supports" and "Infill" dropdowns, which seem to use a different widget, are not impacted.

The Preset dropdown in the other settings tabs is fine too. It appears to use the same widgets as the first 3, but has a greater height.

My guess is, there is probably a maximum height applied on these 3 widgets, which would explain why all themes are not impacted.

Screenshots

This is the issue:
Screenshot_20201218_110739_arrow

This is fine:
Screenshot_20201218_110919

@nordurljosahvida
Copy link
Contributor

After the fixes of #4135 #4135 I just noted instead some horizontal cuts in 2.3.0-rc2 GTK3 appimage under Ubuntu 20 HiDPI screen.

Skjámynd frá 2021-01-03 14-51-11

Skjámynd frá 2021-01-03 14-54-16

This happens with multiple printers and filaments but does not affect all, cannot find a pattern for now. Print profile box is unaffected.

@bubnikv
Copy link
Collaborator

bubnikv commented Jan 4, 2021

Do you have any filament and printer profile with an excessively long name?
Maybe the GTK widget formats according to the longest text in the combo box?

@nordurljosahvida
Copy link
Contributor

Aha, that's right. I have some physical printer printer names that are longer, same things with filaments. Should we enforce a left-justification of text when the menu isn't open?

@bubnikv
Copy link
Collaborator

bubnikv commented Jan 5, 2021

BTW how does the combo box look like when rolled down? Are the texts clipped as well?

@bubnikv
Copy link
Collaborator

bubnikv commented Jan 5, 2021 via email

@nordurljosahvida
Copy link
Contributor

Thanks for looking into this.

When open the menu overflows into the left and right [therefore off-screen, or at least until the very edge] so the text isn't clipped.

Skjámynd frá 2021-01-05 16-36-22
Screenshot 2021-01-05 16:36:00

tamasmeszaros added a commit that referenced this issue Jan 11, 2021
YuSanka added a commit that referenced this issue Jan 12, 2021
@vintagepc
Copy link

vintagepc commented Jul 4, 2021

I see some commits so I'm guessing it may have already been fixed but I'll add in that I'm also observing this on KDE with a similar dark theme:
image

Possibly related but this is on a 4K display with all scaling forced off (i.e. 100%/locked at 96x96 DPI)

YuSanka added a commit that referenced this issue Jul 7, 2021
@jeanblanchard
Copy link
Author

I can confirm the issue is fixed in PrusaSlicer 2.3.2, released today 🎉

Thanks @vintagepc for bringing it up right in time in the RC phase for the fix to be backported before the release 👍

image

@vintagepc
Copy link

🎉 whoo, update! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants