-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
../src/gtk/listbox.cpp(661): assert ""HasFlag(0x0020)"" failed in GetSelection(): must be single selection listbox #5152
Comments
This is still an issue in current master. |
@YuSanka this issue still exists in beta3 |
Unfortunately, I can't reproduce this issue |
Xubuntu 20.04 with wxGTK 3.1.4
Why wxGTK 3.1.4? Where did you get it?
Linux Desktop as a platform:
https://www.youtube.com/watch?v=VoP1E9J4jpg
po 14. 12. 2020 v 16:54 odesílatel Oleksandra Yushchenko <
[email protected]> napsal:
… Unfortunately, I can't reproduce this issue
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5152 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMPSI6EAS7C3BOTXBYEQWTSUYYM3ANCNFSM4TU3OLSQ>
.
|
Why wxGTK 3.1.4? Where did you get it?
I mean, 3.1.4 is considered unstable by linux folk, distros insist on 3.0.
We do compile against patched 3.1.3.
po 14. 12. 2020 v 17:09 odesílatel Vojtech Bubnik <[email protected]>
napsal:
… > Xubuntu 20.04 with wxGTK 3.1.4
Why wxGTK 3.1.4? Where did you get it?
Linux Desktop as a platform:
https://www.youtube.com/watch?v=VoP1E9J4jpg
po 14. 12. 2020 v 16:54 odesílatel Oleksandra Yushchenko <
***@***.***> napsal:
> Unfortunately, I can't reproduce this issue
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#5152 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABMPSI6EAS7C3BOTXBYEQWTSUYYM3ANCNFSM4TU3OLSQ>
> .
>
|
Well that's not that quite right. the WX project, still considers 3.1.x a development release, thus distro's in general are reluctant to ship it. The fact that the WX project encourages people to use 3.1 while not declaring it a stable release, is mixed messaging in a very bad way. Why 3.1.3, and not 3.1.4? Patched how? Have those patches been upstreamed?
Because I noticed you were building against 3.1.x, so I thought I'd try it. It's basically the debian packaging for 3.0.x locally updated for 3.1.4. If I recall correctly this was reproducable using wxGTK 3.0.4, but I'll retest that and report back. |
Frankly this is how I feel supporting PrusaSlicer on Linux: https://twitter.com/bubnikv/status/1337829698450186243 Supporting Linux builds self compiled using "some" dependencies of an unknown state, linked against "some" wxWidgets and "some" GTK on "some" linux with "some" GTK skinning is so fragile, it really feels like the proverbial mole whacking. I am seriously considering to support just our binary builds. If you compile yourself, you are on your own. We do compile using patched wxWidgets and static libraries, those are compiled using the CMake scripts from the deps directory. |
@YuSanka I just realized, I may have omited crucial information to reproduce (sorry about that): mv .config/PrusaSlicer-beta/ .config/PrusaSlicer-beta-old/ @bubnikv while I sympatize that supporting Linux broadly can be painful at times, having worked on a nontrivial project some time ago. You're probably having a worse than average time than average probably due to WX, which I realize was inherited from slic3r... I would implore you to try to keep supporting local builds at least on the large desktops distros like Fedora/Ubuntu, as the ability to build locally is critical for anybody to do any kind of contribution. |
We certainly will support self compilation on Linux through the static deps build scripts. |
I can't reproduce this with your AppImage builds. This issue is reproducable with wxGTK 3.0.4 shipped with Ubuntu 20.04 |
I just noticed another thing, that might be related, when I enable all filament profiles for (say a newly added Ender3), it seems When only the default filament profiles are selected (when newly adding an Ender3), the default is honored. (This isn't obvious with the current Creality.ini, as Creality PLA is also the first in the search order, but when we change |
When I build against 3.1.3-patched (built locally outside of the Prusa deps build scripts), I still have this issue. It seems the Prusa deps build script explicitly turn off assertions: But presumably those assertions are there for a reason, and the wx folks have consciously enabled them by default. So this issue isn't related to wx3.0 vs 3.1.3-patched, your internal library builds are preventing these regression from being noticed during development. While one might argue whether assertions should be enabled for production builds (even though the wx folks think so), during develop you should consider enabling assertions. |
This may offer a short term workaround: |
I just tested that adding |
…t be single selection listbox This assert was invoked by list_printer->GetSelection() because of list_printer was created with wxLB_MULTIPLE flag.
I was finally able to reproduce this assert. Thanks for your report. |
…t be single selection listbox This assert was invoked by list_printer->GetSelection() because of list_printer was created with wxLB_MULTIPLE flag.
@YuSanka the fix committed to correct this issue has broken building with wx 3.0 (aka stable) |
Confirmed, thank you! |
…(): must be single selection listbox This assert was invoked by list_printer->GetSelection() because of list_printer was created with wxLB_MULTIPLE flag.
Fixed in upcoming PrusaSlicer 2.4.0-alpha1. |
Version
2.3.0~alpha3+83~gcd2b502c3
Operating system type + version
Xubuntu 20.04 with wxGTK 3.1.4
3D printer brand / version + firmware version (if known)
Creality Ender-3 BLTouch
Behavior
In the Configuration Wizard in the Filaments tab, I'm getting this, when I'm switching between filaments types after having pressed "Select All":
The text was updated successfully, but these errors were encountered: