Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export gcode de and Remove SD button #4212

Closed
Davidrenaud314 opened this issue May 7, 2020 · 2 comments
Closed

Export gcode de and Remove SD button #4212

Davidrenaud314 opened this issue May 7, 2020 · 2 comments

Comments

@Davidrenaud314
Copy link

Version 2.2.0

Win 10 pro 64 bit

I3MK3S latest version

Behavior

additional buttons to save directly on SD card are great.
image

But the “eject button” appear on the screen before the end of the Gcode check and if I click eject to early, I get a message:
image

I need to wait the end of the export process before eject. In that case I get no error.
I may recommend that eject button appear after the export process is completed.

  • Steps needed to reproduce the problem
    Export a Gcode on SD card and click eject as soon as it appear to get error message. Wait end of the process to click and message do not appear.
@JohnnyDeer
Copy link

Hi @Davidrenaud314 , issue reproduced and confirmed, thank you for reporting.

jschuh added a commit to jschuh/PrusaSlicer that referenced this issue Aug 1, 2020
* Use the correct LIBPNG

* ENABLE_LAYOUT_NO_RESTART -> Added an extra sizer to Mainframe to avoid hiding the entire application when switching the layout type

* Fixed initial size of features type combo popup when building against wxWidgets 3.1.3

* Fix macos deps

* prusa3d#4492 - Fixed application loosing focus when importing models

* Attempt to fix crash on Mac when rotating an object while layer editing is active

* Support for collecting warnings from the background processing.

Multiple warnigns may be collected per Print / PrintObject milestone
and a status update is sent to the UI immediately after a warning
is issued.

* Update of back-end warnings:
Back-end warnings contain two new members: "current" and "message_id".
A warning is set to "not current" if its milestone is invalidated.

* Fix of previous commit.

* Empty layers check converted to a warning (except for the first layer)

* Pull request prusa3d#4235 - Fix tick/untick ironing feature in preview by rongith

* Empty layer check fix
The test gave false positive in case there were supposed to be both object and support extrusions on the first layer

* Added well-known metadata to 3mf export

* GUI_objectList: fixed typo in assert

* Fixed back-end warning infrastructure: The Print / PrintObject
should have been derived from ObjectBase, not from ObjectID.

* Temporary ironing icon to avoid crashes on GTK
Ironing type and spacing can be set per-object

* Fixed update of the TreeCtrls and "revert to system values" buttons on preset tabs, if application was run in New or Dlg mode

* Fixed a bug in selection from the 3D scene.

Steps to the reproduce a crash:
1. In SLA mode add some object with several instances
2. Slice
3. Back to 3Dview scene, select all using Ctrl+A
4. Press "Delete"

* Hot fix for the last commit

* TriangleSelector: draft of interface

* TriangleSelector: first partially working implementation

* TriangleSelector: Improvements

* TriangleSelector: even more progress

* TriangleSelector: remerging triangles, bugfixes

* TriangleSelector: Reusing of previously calculated triangle divisions, partial garbage collection implementation

* TriangleSelector: Vertices are reference-counted and garbage collected
Garbage collection is triggered automatically when more than half of all triangles are invalid

* TriangleSelector: getting ready for frontend/backend separation

* TriangleSelector: Serialization and deserialization

* TriangleSelector: Separated frontend/backend, support of multiple volumes, etc.

* TriangleSelector: 'Select by angle' and 'reset selection' functions fixed

* TriangleSelector: backend is aware of divided triangles

* TriangleSelector: Schedule restarting background process after edit

* TriangleSelector: Fix of a macOS crash
Calling reset() from constructor relied on uninitialized variable

* TriangleSelector: bugfix - backend did not correctly account for mirrorring

* TriangleSelector: edge limit is derived from cursor size

* TriangleSelector: 3MF loading and saving

* Showing Eject button only after exporting is finished. Fix of prusa3d#4212

* added 's' in https when pointing users to our github

* Deleted default value in Plater::export_gcode(bool prefer_removable). Only place where it is not sure what value should be is in btn_reslice - i chose true

* Added handling of mouse wheel events to ImGuiWrapper

Co-authored-by: bgiot <[email protected]>
Co-authored-by: enricoturri1966 <[email protected]>
Co-authored-by: tamasmeszaros <[email protected]>
Co-authored-by: Vojtech Bubnik <[email protected]>
Co-authored-by: Lukas Matena <[email protected]>
Co-authored-by: YuSanka <[email protected]>
Co-authored-by: rongith <[email protected]>
Co-authored-by: David Kocik <[email protected]>
jschuh added a commit to jschuh/PrusaSlicer that referenced this issue Aug 1, 2020
* Use the correct LIBPNG

* ENABLE_LAYOUT_NO_RESTART -> Added an extra sizer to Mainframe to avoid hiding the entire application when switching the layout type

* Fixed initial size of features type combo popup when building against wxWidgets 3.1.3

* Fix macos deps

* prusa3d#4492 - Fixed application loosing focus when importing models

* Attempt to fix crash on Mac when rotating an object while layer editing is active

* Support for collecting warnings from the background processing.

Multiple warnigns may be collected per Print / PrintObject milestone
and a status update is sent to the UI immediately after a warning
is issued.

* Update of back-end warnings:
Back-end warnings contain two new members: "current" and "message_id".
A warning is set to "not current" if its milestone is invalidated.

* Fix of previous commit.

* Empty layers check converted to a warning (except for the first layer)

* Pull request prusa3d#4235 - Fix tick/untick ironing feature in preview by rongith

* Empty layer check fix
The test gave false positive in case there were supposed to be both object and support extrusions on the first layer

* Added well-known metadata to 3mf export

* GUI_objectList: fixed typo in assert

* Fixed back-end warning infrastructure: The Print / PrintObject
should have been derived from ObjectBase, not from ObjectID.

* Temporary ironing icon to avoid crashes on GTK
Ironing type and spacing can be set per-object

* Fixed update of the TreeCtrls and "revert to system values" buttons on preset tabs, if application was run in New or Dlg mode

* Fixed a bug in selection from the 3D scene.

Steps to the reproduce a crash:
1. In SLA mode add some object with several instances
2. Slice
3. Back to 3Dview scene, select all using Ctrl+A
4. Press "Delete"

* Hot fix for the last commit

* TriangleSelector: draft of interface

* TriangleSelector: first partially working implementation

* TriangleSelector: Improvements

* TriangleSelector: even more progress

* TriangleSelector: remerging triangles, bugfixes

* TriangleSelector: Reusing of previously calculated triangle divisions, partial garbage collection implementation

* TriangleSelector: Vertices are reference-counted and garbage collected
Garbage collection is triggered automatically when more than half of all triangles are invalid

* TriangleSelector: getting ready for frontend/backend separation

* TriangleSelector: Serialization and deserialization

* TriangleSelector: Separated frontend/backend, support of multiple volumes, etc.

* TriangleSelector: 'Select by angle' and 'reset selection' functions fixed

* TriangleSelector: backend is aware of divided triangles

* TriangleSelector: Schedule restarting background process after edit

* TriangleSelector: Fix of a macOS crash
Calling reset() from constructor relied on uninitialized variable

* TriangleSelector: bugfix - backend did not correctly account for mirrorring

* TriangleSelector: edge limit is derived from cursor size

* TriangleSelector: 3MF loading and saving

* Showing Eject button only after exporting is finished. Fix of prusa3d#4212

* added 's' in https when pointing users to our github

* Deleted default value in Plater::export_gcode(bool prefer_removable). Only place where it is not sure what value should be is in btn_reslice - i chose true

* Added handling of mouse wheel events to ImGuiWrapper

Co-authored-by: bgiot <[email protected]>
Co-authored-by: enricoturri1966 <[email protected]>
Co-authored-by: tamasmeszaros <[email protected]>
Co-authored-by: Vojtech Bubnik <[email protected]>
Co-authored-by: Lukas Matena <[email protected]>
Co-authored-by: YuSanka <[email protected]>
Co-authored-by: rongith <[email protected]>
Co-authored-by: David Kocik <[email protected]>
@rtyr
Copy link
Collaborator

rtyr commented Feb 17, 2021

Fixed. Closing.

@rtyr rtyr closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants