-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thin wall: Gapfill not working #32
Comments
Which version of Alexrj's Slic3r are you referring to? On Sat, Nov 12, 2016 at 5:59 PM, Sebastianv650 [email protected]
|
The latest code from the Master branch: 8910b49 |
Thanks. From the top of my head I am aware of no change, which could lead On Sat, Nov 12, 2016 at 6:25 PM, Sebastianv650 [email protected]
|
Thanks, I have reverted a recent commit, which causes this behavior. I did not quite understand the code, now I believe I do much better. Learning by a trial and error, but I am slowly getting confident with the Slic3r internals. It took quite a long time indeed. It is also an answer, why there are not many contributors to Slic3r, as it takes quite some time to work in. We at Prusa3D have the "detect thin walls" off as it introduces unnecessary roundings of the perimeters, which then need to be filled in by the not very reliable gap fill. There is still room for improvement indeed. Thanks for keeping watch over this fork and for doing a great testing job. I hope with this commit we can release a useful build to the world. |
I have no good explanation for that. On Sat, Nov 12, 2016 at 6:27 PM, bubnikv . [email protected] wrote:
|
Is the double infill bug away if you disable the "ensure verticall wall On Sat, Nov 12, 2016 at 7:59 PM, Sebastianv650 [email protected]
|
This pictures are without ensure vertical wall thickness, i have not tried enabling it with this model. But I will test it.. |
thanks, that enough. On Sat, Nov 12, 2016 at 8:31 PM, Sebastianv650 [email protected]
|
Happens with and without ensure vertical wall thickness. |
I fixed a bug I have introduced recently (again). Thanks for pointing this out. |
Reverts an inadverent bug introduced in prusa3d/PrusaSlicer@4460b5c Conflicts: xs/src/libslic3r/PerimeterGenerator.cpp
Version
c1af9bd
Operating system type + version
Win 10 64bit
Behavior
Even with detect thin walls enabled, Slic3r tries to fill the thin walls of the model in the upper area with 2 perimeters, that would result in masive over-extrusion. A few layers down, where the wall thickness is a little bit lower, it creates 1 perimeter with a gapfill-infill as desired.
3D Preview of the over-filled layer, you can baraly see the 2 perimeters:
2D View of the layer:
Alexrj's Slic3r did a good job on the model, same layer, same settings:
It looks to me as in prusa3d-Slic3r the gap fill line width is limited to a max. value. If that line width is exceeded, it tries to use normal perimeters without a check that this can't work?
Excelent gapfill of thin walls is the main reason I love Slic3r, so it would be great if this version can keep this feature at the same quality :-)
Another thing I noticed during slicing the model: alexrj Slic3r says Manifold: yes. Prusa Slic3r is stating over 800 errors in the model? Might be related, but maybe not..
STL/Config (.ZIP) where problem occurs
http://www.thingiverse.com/thing:1817180
The text was updated successfully, but these errors were encountered: