Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thin wall: Gapfill not working #32

Closed
Sebastianv650 opened this issue Nov 12, 2016 · 11 comments
Closed

Thin wall: Gapfill not working #32

Sebastianv650 opened this issue Nov 12, 2016 · 11 comments

Comments

@Sebastianv650
Copy link

Version

c1af9bd

Operating system type + version

Win 10 64bit

Behavior

Even with detect thin walls enabled, Slic3r tries to fill the thin walls of the model in the upper area with 2 perimeters, that would result in masive over-extrusion. A few layers down, where the wall thickness is a little bit lower, it creates 1 perimeter with a gapfill-infill as desired.
3D Preview of the over-filled layer, you can baraly see the 2 perimeters:
prusa
2D View of the layer:
prusa_2

Alexrj's Slic3r did a good job on the model, same layer, same settings:
orig

It looks to me as in prusa3d-Slic3r the gap fill line width is limited to a max. value. If that line width is exceeded, it tries to use normal perimeters without a check that this can't work?
Excelent gapfill of thin walls is the main reason I love Slic3r, so it would be great if this version can keep this feature at the same quality :-)

Another thing I noticed during slicing the model: alexrj Slic3r says Manifold: yes. Prusa Slic3r is stating over 800 errors in the model? Might be related, but maybe not..

STL/Config (.ZIP) where problem occurs

http://www.thingiverse.com/thing:1817180

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 12, 2016

Which version of Alexrj's Slic3r are you referring to?

On Sat, Nov 12, 2016 at 5:59 PM, Sebastianv650 [email protected]
wrote:

Version

c1af9bd
c1af9bd
Operating system type + version

Win 10 64bit
Behavior

Even with detect thin walls enabled, Slic3r tries to fill the thin walls
of the model in the upper area with 2 perimeters, that would result in
masive over-extrusion. A few layers down, where the wall thickness is a
little bit lower, it creates 1 perimeter with a gapfill-infill as desired.
3D Preview of the over-filled layer, you can baraly see the 2 perimeters:
[image: prusa]
https://cloud.githubusercontent.com/assets/10776877/20239476/1c5e7b72-a901-11e6-903a-82822682ec9e.JPG
2D View of the layer:
[image: prusa_2]
https://cloud.githubusercontent.com/assets/10776877/20239479/26375024-a901-11e6-851e-e69fb2e0543e.JPG

Alexrj's Slic3r did a good job on the model, same layer, same settings:
[image: orig]
https://cloud.githubusercontent.com/assets/10776877/20239485/34f474f2-a901-11e6-9d8b-325fb9fc30cc.JPG

It looks to me as in prusa3d-Slic3r the gap fill line width is limited to
a max. value. If that line width is exceeded, it tries to use normal
perimeters without a check that this can't work?
Excelent gapfill of thin walls is the main reason I love Slic3r, so it
would be great if this version can keep this feature at the same quality :-)

Another thing I noticed during slicing the model: alexrj Slic3r says
Manifold: yes. Prusa Slic3r is stating over 800 errors in the model? Might
be related, but maybe not..
STL/Config (.ZIP) where problem occurs

http://www.thingiverse.com/thing:1817180


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#32, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFj5I1-vrPPiJANLhPERZ0NgsXC9ZLCIks5q9fB7gaJpZM4Kwd1q
.

@Sebastianv650
Copy link
Author

The latest code from the Master branch: 8910b49
I only added some PRs to fix autocooling and other small things that are broken in the current version.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 12, 2016

Thanks. From the top of my head I am aware of no change, which could lead
to such a behavior, but I will dig into it.

On Sat, Nov 12, 2016 at 6:25 PM, Sebastianv650 [email protected]
wrote:

The latest code from the Master branch: 8910b49
8910b49
I only added some PRs to fix autocooling and other small things that are
broken in the current version.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#32 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFj5I9kjRtVfYvTq4-IXmXIbyy2j4F9-ks5q9fafgaJpZM4Kwd1q
.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 12, 2016

Thanks, I have reverted a recent commit, which causes this behavior. I did not quite understand the code, now I believe I do much better. Learning by a trial and error, but I am slowly getting confident with the Slic3r internals. It took quite a long time indeed. It is also an answer, why there are not many contributors to Slic3r, as it takes quite some time to work in.

We at Prusa3D have the "detect thin walls" off as it introduces unnecessary roundings of the perimeters, which then need to be filled in by the not very reliable gap fill. There is still room for improvement indeed.

Thanks for keeping watch over this fork and for doing a great testing job. I hope with this commit we can release a useful build to the world.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 12, 2016

Another thing I noticed during slicing the model: alexrj Slic3r says
Manifold: yes. Prusa
Slic3r is stating over 800 errors in the model? Might be related, but
maybe not..

I have no good explanation for that.

On Sat, Nov 12, 2016 at 6:27 PM, bubnikv . [email protected] wrote:

Thanks. From the top of my head I am aware of no change, which could lead
to such a behavior, but I will dig into it.

On Sat, Nov 12, 2016 at 6:25 PM, Sebastianv650 [email protected]
wrote:

The latest code from the Master branch: 8910b49
8910b49
I only added some PRs to fix autocooling and other small things that are
broken in the current version.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#32 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFj5I9kjRtVfYvTq4-IXmXIbyy2j4F9-ks5q9fafgaJpZM4Kwd1q
.

@Sebastianv650
Copy link
Author

Sebastianv650 commented Nov 12, 2016

It took quite a long time indeed. It is also an answer, why there are not many contributors to Slic3r, as it takes quite some time to work in.

Absolutely true! I would love to contribute more actively to Slic3r, but up to now I found no starting point. I think you need real passion to dig into how slicers work..
And I'm very glad you are continuing alexrjs work in such an activ maner since it looks he retired from development at the moment.

We at Prusa3D have the "detect thin walls" off as it introduces unnecessary roundings of the perimeters, which then need to be filled in by the not very reliable gap fill. There is still room for improvement indeed.

Might be true, but it's the best available at the marked. ☺️ My experience with it is quite good, the parts I'm printing are 50% impossible to slice with Cura or Simplify3D due to thin elements.

I tested your recent change, it's nearly working now. See the following screenshots at layer height 35.8mm, it's now creating the gap fill but does a zig-zag infill also. 2D view also shows this:
double-infill
double-infill_2d
If this can be solved also, it would be perfect.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 12, 2016

Is the double infill bug away if you disable the "ensure verticall wall
thickness" feature? It may be, that it does not take the gapfill into
account. Thanks.

On Sat, Nov 12, 2016 at 7:59 PM, Sebastianv650 [email protected]
wrote:

It took quite a long time indeed. It is also an answer, why there are not
many contributors to Slic3r, as it takes quite some time to work in.

Absolutely true! I would love to contribute more actively to Slic3r, but
up to now I found no starting point. I think you need real passion to dig
into how slicers work..
And I'm very glad you are continuing alexrjs work in such a activ maner
since it looks he retired from development at the moment.

We at Prusa3D have the "detect thin walls" off as it introduces
unnecessary roundings of the perimeters, which then need to be filled in by
the not very reliable gap fill. There is still room for improvement indeed.

Might be true, but it's the best available at the marked. :simple_smile:
My experience with it is quite good, the parts I'm printing are 50%
impossible to slice with Cura or Simplify3D due to thin elements.

I tested your recent change, it's nearly working now. See the following
screenshots at layer height 35.8mm, it's now creating the gap fill but does
a zig-zag infill also. 2D view also shows this:
[image: double-infill]
https://cloud.githubusercontent.com/assets/10776877/20240185/6c95765c-a912-11e6-9c92-52255043a829.JPG
[image: double-infill_2d]
https://cloud.githubusercontent.com/assets/10776877/20240186/732e7338-a912-11e6-8be7-6e916827d2b5.JPG
If this can be solved also, it would be perfect.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#32 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFj5I_RUr1F_bN91uiB4HxdeR50wHRReks5q9gyagaJpZM4Kwd1q
.

@Sebastianv650
Copy link
Author

This pictures are without ensure vertical wall thickness, i have not tried enabling it with this model. But I will test it..

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 12, 2016

thanks, that enough.

On Sat, Nov 12, 2016 at 8:31 PM, Sebastianv650 [email protected]
wrote:

This pictures are without ensure vertical wall thickness, i have not tried
enabling it with this model. But I will test it..


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#32 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFj5I3mnI04m6sTb3A-jDxsi2mp9QISQks5q9hQFgaJpZM4Kwd1q
.

@Sebastianv650
Copy link
Author

Happens with and without ensure vertical wall thickness.

bubnikv added a commit that referenced this issue Nov 12, 2016
@bubnikv
Copy link
Collaborator

bubnikv commented Nov 12, 2016

I fixed a bug I have introduced recently (again). Thanks for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants