Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties unreadable, Windows 10, dark themes. #3038

Closed
promacjoe opened this issue Oct 6, 2019 · 17 comments
Closed

Properties unreadable, Windows 10, dark themes. #3038

promacjoe opened this issue Oct 6, 2019 · 17 comments

Comments

@promacjoe
Copy link

Version

Version of PrusaSlicer used goes here
2.1.0 Win64

Use About->About PrusaSlicer for release versions

For -dev versions, use git describe --tag or get the hash value for the version you downloaded or git rev-parse HEAD

Operating system type + version

What OS are you using, and state any version #s
In case of 3D rendering issues, please attach the content of menu Help -> System Info dialog
Windows 10, fully updated.

3D printer brand / version + firmware version (if known)

What 3D printer brand / version are you printing on, is it a stock model or did you modify the printer, what firmware is running on your printer, version of the firmware #s
Program UI problem, Not related to 3D printer.

Behavior

  • Describe the problem Properties with unreadable, when using Windows 10 dark themes.

  • Steps needed to reproduce the problem Windows accessibility options, dark themes.

    • If this is a command-line slicing issue, include the options used
  • Expected Results System should be readable for all individuals, including the visually impaired.
    If you are going to use system font colors, use system background colors as well. It's a stupid mistake that Too many programmers make.

  • Actual Results

    • Screenshots from PrusaSlicer preview are preferred

Is this a new feature request?

Project File (.3MF) where problem occurs

Upload a PrusaSlicer Project File (.3MF) (Plater -> Export plate as 3MF for Slic3r PE 1.41.2 and older, File -> Save / Save Project for PrusaSlicer, Slic3r PE 1.42.0-alpha and newer)
Images (PNG, GIF, JPEG), PDFs or text files could be drag & dropped to the issue directly, while all other files need to be zipped first (.zip, .gz)

@Jebtrix
Copy link
Contributor

Jebtrix commented Oct 6, 2019

I see no affect of Dark mode in Windows 10 with PrusaSlicer. Can you provide a screenshot and possibly what settings you changed in Windows?

@promacjoe
Copy link
Author

Let me guess, that's what I would have to be doing if I wanted to use your program. Since no explanation of any of these settings are readable on my computer.
I'm not wishing to sound sarcastic, but it is very annoying to try to use a program, That the text is the same color as the background. I am not a programmer, but I have done some programming. And I know how easy this mistake can be made. But if you're legally blind like I am, you would know how often this situation comes up. And it is frustrating. If you are going to use system colors for your fonts, use system colors for your backgrounds.

Image6
Image7
Image8
Image9
Image10
![Image1](https://user-images.githubusercontent.com/55812301/66283487-4fe3bf00-
e889-11e9-9bcd-ca8a3bb92f62.png)
Image2
Image3
Image4
Image5

@Jebtrix
Copy link
Contributor

Jebtrix commented Oct 7, 2019

That is accessibility High Contrast Black. I wouldn't consider that a Dark theme in the traditional sense. You are the first to bring it to the attention of the devs. They have already dealt with colorblind problems in the past #1986 so they are receptive to importance of accessibility. I see nothing in my question that provoked such a tone. Devs here are pretty great, I'm sure they will handle this with the consideration it deserves.

@promacjoe
Copy link
Author

I'm sorry if I sounded sarcastic, but my frustration for this type of problem is showing. I am using one of the standard Windows 10 accessibility themes. There is nothing special about it. But this has been a ongoing problem for years. This problem even exist in some programs designed for the Partially blind. And my complaints seem to be ignored. Sometimes I think it will take an act of Congress to fix this problem, but they seem to be too busy conducting a witchhunt. Again my apologies. And I appreciate any help you can give.

@ghost
Copy link

ghost commented Mar 20, 2020

Any news from devs? There is more people (including me) who needs to use windows high contrast theme. I am partially visual impairment user and white&light backgrounds are kryptonite for my eyes. Currently Prusaslicer is nightmare to use and it is big disappoint when you have Prusa printer but cant use prusaslicer.

I have seen some pics from Prusaslicer mac version which supports dark mode and it looks good. I wish we get that to Windows version soon. Or better support for windows high contrast themes.

@bubnikv
Copy link
Collaborator

bubnikv commented Mar 20, 2020 via email

@ghost
Copy link

ghost commented Mar 20, 2020

Ok, sorry to hear but i keep fingers crossed.

Btw, older SlicerPE versions works well with high contrast themes, what is changed?

@bubnikv
Copy link
Collaborator

bubnikv commented Mar 20, 2020

I am not sure, but we had a hard time implementing support for high resolution displays. There was a huge amount of changes around the UI code since Slic3r PE.

@ghost
Copy link

ghost commented Mar 20, 2020

Ok, thanks for your replies. It might be better to wait Microsoft dark mode APIs and then make dark mode available which overrides high contrast theme. Dark mode is not that good as high contrast theme is but dark mode is thousand times better than white backgrounds.

In best case there should be both, dark mode and support for high contrast themes. Then visual impairment (and other users too) user can select from app settings which one works better. But i am happy if either option is supported in near future.

@fernandex00
Copy link

Hi, is there any update for this?I can't find any info about win32 apps theme support from windows

@ghost
Copy link

ghost commented Oct 10, 2020

For me it looks like a Prusa devs are bit lazy when blaming Microsoft about that API. It is not that hard to create an option for a dark theme or studying and try what windows high contrast theme is and fine tune colors to for it. Even a temporary dark theme would be nice until Microsoft fixes their dark mode APIs, if that never happens.

@slohmaier
Copy link

I use the function: wxSystemSettings::GetAppearance().IsDark()
https://github.com/slohmaier/PrusaSlicer/commit/0930d93f1c825caffa508ae4ef806f48a19554b7
This works for HighContrast white and High Contras Black Windows themes:
dark
white
I'm a newbie to wxWidgets and PrusaSlicer. Is this flag good enough?

@YuSanka
Copy link
Collaborator

YuSanka commented Apr 7, 2021

Thanks for your reports and suggestion(@slohmaier). High Contrast themes are fixed now in PrusaSlicer with effad84 and will be a part of next release

@ghost
Copy link

ghost commented Jul 9, 2021

Thanks for your reports and suggestion(@slohmaier). High Contrast themes are fixed now in PrusaSlicer with effad84 and will be a part of next release

Is this fix added soon for Prusaslicer?

@MarkNahabedian
Copy link

I am experiencing this problem with PrusaSlicer Version 2.3.3+win64.

Labels are invisible under the "High Contrast Black" theme. Also, I can't see how to exit the settings screen so I quit PrusaSlicer entirely.

What do I need to do to get visible settings dialogs?

@bubnikv
Copy link
Collaborator

bubnikv commented Aug 11, 2021

@YuSanka believes the high contrast theme has been fixed in master with effad84
The fix will be released with PrusaSlicer 2.4.0-alpha1.

Also we now support Dark Mode on Windows, see #4493

@bubnikv bubnikv closed this as completed Aug 11, 2021
@MarkNahabedian
Copy link

MarkNahabedian commented Aug 12, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants