Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'only overhang layer has more than one speed' test failed #2

Closed
CReimer opened this issue Nov 1, 2016 · 18 comments
Closed

'only overhang layer has more than one speed' test failed #2

CReimer opened this issue Nov 1, 2016 · 18 comments

Comments

@CReimer
Copy link

CReimer commented Nov 1, 2016

While compiling this for Arch Linux there's an error message while running through the tests.

t/perimeters.t ................. 46/59 
#   Failed test 'only overhang layer has more than one speed'
#   at t/perimeters.t line 281.
#          got: '0'
#     expected: '1'
t/perimeters.t ................. 59/59 # Looks like you failed 1 test of 59.
t/perimeters.t ................. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/59 subtests 
@bubnikv
Copy link
Collaborator

bubnikv commented Nov 2, 2016

Thanks, but this is a little too little to draw any conclusion from.

What Arch Linux? What version? 32bit or 64bit? What gcc version? What perl version? It would greatly help, if you could provide a build log, which contains the compilation flags with which the GCC compiler is executed.

@CReimer
Copy link
Author

CReimer commented Nov 2, 2016

Yes, of course. There's no Arch Linux version it's a rolling release distribution.
It's 64bit
gcc version is 6.2.1 20160830
perl version is v5.24.0
buildlog.txt

And here's the PKGBUILD script: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=slic3r-prusa3d
It's still a bit of a mess, but I'm yet to find an easier solution to compile slic3r into a distribution package.

@flannelhead
Copy link
Contributor

I can also confirm this. Same OS and software versions as @CReimer. I'm not building with the above PKGBUILD script but manually with locally installed Perl packages using these instructions.

@flannelhead
Copy link
Contributor

Reverting c443f49 does seem to fix this test for me but fails another test "seam is aligned". @CReimer, can you confirm?

I might investigate this a bit further as there is something C++11 related (std::swap) going on in that commit.

@flannelhead
Copy link
Contributor

Well, seems to not be C++11 related. Compiling with -std=c++98 (the standard that's default in older gcc) gives the same test failure.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 3, 2016

Looks like I would have to install the ArchLinux beauty into a virtual machine.

@flannelhead
Copy link
Contributor

flannelhead commented Nov 3, 2016

@bubnikv I guess any Linux distro with a recent enough gcc (preferably >= 6.1) would be good. Arch Linux is probably a bit of a hassle to set up (you'll have to roll the install manually step by step).

Otherwise, it wouldn't be a bad idea to test the builds on a Linux VM. Fedora, maybe? Or Debian testing.

@CReimer
Copy link
Author

CReimer commented Nov 3, 2016

If installing Arch Linux is too much of a hassle you can always use Antergos instead.
Even though it's not as beautiful as Arch Linux 😄

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 3, 2016

We run our builds on Debian, but the server may not be quite up to date.

On Thu, Nov 3, 2016 at 6:24 PM, CReimer [email protected] wrote:

If installing Arch Linux is too much of a hassle you can always use
Antergos instead.
Even though it's not as beautiful as Arch Linux 😄


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFj5I4SeHhK4T6HnZ8O66z-dVkzURuZzks5q6hjTgaJpZM4KmSac
.

@CReimer
Copy link
Author

CReimer commented Nov 3, 2016

I'm not sure how helpful it is, but that's the content of %layer_speeds in perimeters.t

# $VAR1 = {
#           '0.350' => {
#                      '3960' => 1
#                    },
#           '4.250' => {
#                      '3960' => 1
#                    },
#           '3.050' => {
#                      '3960' => 1
#                    },
#           '1.850' => {
#                      '3960' => 1
#                    },
#           '1.550' => {
#                      '3960' => 1
#                    },
#           '4.550' => {
#                      '3960' => 1
#                    },
#           '3.350' => {
#                      '5940' => 1
#                    },
#           '5.450' => {
#                      '3960' => 1
#                    },
#           '0.950' => {
#                      '3960' => 1
#                    },
#           '4.850' => {
#                      '3960' => 1
#                    },
#           '2.150' => {
#                      '3960' => 1
#                    },
#           '6.050' => {
#                      '3960' => 1
#                    },
#           '2.450' => {
#                      '3960' => 1
#                    },
#           '6.350' => {
#                      '3960' => 1
#                    },
#           '5.150' => {
#                      '3960' => 1
#                    },
#           '5.750' => {
#                      '3960' => 1
#                    },
#           '3.950' => {
#                      '3960' => 1
#                    },
#           '2.750' => {
#                      '3960' => 1
#                    },
#           '1.250' => {
#                      '3960' => 1
#                    },
#           '3.650' => {
#                      '3960' => 1
#                    },
#           '0.650' => {
#                      '3960' => 1
#                    }
#         };

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 3, 2016

If installing Arch Linux is too much of a hassle you can always use
Antergos instead.
Even though it's not as beautiful as Arch Linux 😄

There are about 5x more Linux distributions then there are Linux
programmers.

Running the Arch Linux installation. This reminds me of my early 1999
encounters with Slackware Linux, installling from a shoe box of floppies.

On Thu, Nov 3, 2016 at 6:38 PM, bubnikv . [email protected] wrote:

We run our builds on Debian, but the server may not be quite up to date.

On Thu, Nov 3, 2016 at 6:24 PM, CReimer [email protected] wrote:

If installing Arch Linux is too much of a hassle you can always use
Antergos instead.
Even though it's not as beautiful as Arch Linux 😄


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFj5I4SeHhK4T6HnZ8O66z-dVkzURuZzks5q6hjTgaJpZM4KmSac
.

@flannelhead
Copy link
Contributor

flannelhead commented Nov 3, 2016

@CReimer @bubnikv isn't that the expected result? I see one of the layers has a different speed 5940 while the others have 3960. There's something strange going on with the test itself.

Edit: forget it, the test checks for multiple different speeds within one layer. My bad.

@CReimer
Copy link
Author

CReimer commented Nov 3, 2016

On 03.11.2016 19:02, bubnikv wrote:

Running the Arch Linux installation. This reminds me of my early 1999
encounters with Slackware Linux, installling from a shoe box of floppies.

For reasons I don't understand they want to keep their setup like that.
I would have switched to another distribution if Arch weren't that easy
to customize.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 3, 2016

It was not that bad, at least into the virtualbox. I kinda like it, I think I understand why people like 'back to the roots' style.

Running the Build.PL. Let's see.

@flannelhead
Copy link
Contributor

@bubnikv Nice! I will do also some testing on Ubuntu 16.10 on my end to see if it's distro-specific or not.

@flannelhead
Copy link
Contributor

The same test seems to fail on Ubuntu 16.10 as well. gcc 6.2.0 and Perl 5.22.2 there.

bubnikv referenced this issue Nov 3, 2016
into polygons_covered_by_width() and polygons_covered_by_spacing().

Bugfix of ExtrusionLoop::split_at(const Point &point),
where the split ExtrusionPaths were not initialised correctly.
@bubnikv
Copy link
Collaborator

bubnikv commented Nov 3, 2016

Reverting c443f49 does seem to fix this test for me but fails another test "seam is aligned".

Good catch, @flannelhead . Thanks! I introduced this error in c443f49. While I tried to avoid copying a vector of points, I did not intialize the split paths correctly. Following checkin fixes this issue.

483a658

@bubnikv bubnikv closed this as completed Nov 3, 2016
@flannelhead
Copy link
Contributor

@bubnikv Great to see it's fixed, thank you! 🎉 git bisect is sometimes a wonderful tool 😉

bubnikv pushed a commit that referenced this issue Dec 9, 2020
Update to upstream master.
lukasmatena pushed a commit that referenced this issue Jun 24, 2024
@Dollton Dollton mentioned this issue Jul 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants