Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom G-code file extension (.hvs) in output_filename_format not maintained, replaced with .hvs.gcode #1221

Closed
marcoburato opened this issue Sep 11, 2018 · 5 comments

Comments

@marcoburato
Copy link

Version

1.41.0+

Operating system type + version

macOS 10.13.6

Behavior

  • Describe the problem
    When the parameter output_filename_format contains a custom file extension, for instance .hvs, the "save as" dialog will still force the extension to be .gcode, resulting in a file named filename.hvs.gcode.

  • Steps needed to reproduce the problem

    • In Printer Settings > Output options > Output filename format enter [input_filename_base].hvs
    • Slice a model and click Export G-code...
  • Expected Results
    The dialog should use a filename like my_model.hvs.

  • Actual Results
    The dialog uses a filename like my_model.hvs.gcode.
    Note: even if you delete the .gcode, it gets added again when saving the file.

Is this a new feature request?
No

@bubnikv
Copy link
Collaborator

bubnikv commented Sep 11, 2018 via email

@marcoburato
Copy link
Author

My 3D printer, a Cubicon Style, requires files with that extension (plus some custom G-CODE), it won't see .gcode files. The .hvs extension is probably named after the manufacturer (HiVision Systems).
So, having Slic3r save the output file with the correct extension avoids having to rename the file manually.

The default value for that field is [input_filename_base].gcode, so one would expect that changing the file extension is possible.
I suppose the easy fix would be to add the hvs extension to FILE_WILDCARDS["gcode"], although this doesn't address the generic case.

@bubnikv bubnikv changed the title Custom extension in output_filename_format not working properly in UI Custom G-code file extension (.hvs) in output_filename_format not maintained, replaced with .hvs.gcode Sep 27, 2018
@bubnikv
Copy link
Collaborator

bubnikv commented Dec 12, 2018

The upcoming Slic3r 1.42 alpha will maintain your custom extension.
Closing.

@bubnikv bubnikv closed this as completed Dec 12, 2018
@marcoburato
Copy link
Author

@bubnikv This issue is now happening again on 2.6.0. Can you reopen the ticket?

lukasmatena pushed a commit that referenced this issue Sep 1, 2023
Broken with 99861f1 SPE-1207
Custom file extension needs to be included in the list of extensions
of the file dialog. On MacOS the custom extension needs to be the
first one in the list as it will be forced upon the default file
name provided to the file dialog.
eliadevito pushed a commit to eliadevito/PrusaSlicer that referenced this issue Sep 2, 2023
Broken with 99861f1 SPE-1207
Custom file extension needs to be included in the list of extensions
of the file dialog. On MacOS the custom extension needs to be the
first one in the list as it will be forced upon the default file
name provided to the file dialog.
@marcoburato
Copy link
Author

Just confirming this was indeed fixed in 2.6.1. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants