Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridging-Angle not optimal #12

Closed
mgineer85 opened this issue Nov 3, 2016 · 9 comments
Closed

Bridging-Angle not optimal #12

mgineer85 opened this issue Nov 3, 2016 · 9 comments

Comments

@mgineer85
Copy link

mgineer85 commented Nov 3, 2016

Version

1.30 release candidate vs. 1.31.2

Operating system type + version

windows 7 up to date

Behavior

Bridging in the latests release seems to get wrong. See pics. Angle set in the Print-Settings-Infill-Tab is used.
bridging_1 3 2 1
bridging_1 30_release_cand

STL/Config (.ZIP) where problem occurs

Used the same given profiles in both versions from Prusa3D: 0,2mm NORMAL; Prusa PET; Original MK2 ColorPrint
test2.zip

@CReimer
Copy link

CReimer commented Nov 3, 2016

I think it's wrong in both pictures. Shouldn't Slic3r try to keep bridges as short as possible? Something like in the lower picture but rotated by 90°?

@mgineer85
Copy link
Author

Hm,... if it would be rotated by 90° it would try to connect to the perimeters just created and still hot. Believe that would not be as good as in the first picture, but I'm just guessing.

@CReimer
Copy link

CReimer commented Nov 3, 2016

Ahh yes. That makes sense.

bubnikv added a commit that referenced this issue Nov 8, 2016
direction over multiple regions. This allows a single bridge to be
drawn over holes, which are too close to each other to allow
for separate bridges.
Fixes Bridging-Angle not optimal
#12

Re-allowed adaptive infill line width for solid infills. The adaptive
infill line width works in some circumstances, see Issue #15,
but the original implementation often changed the line width too
aggressively. The current implementation limits the line width change
to 20%.
Fixes Gaps between infill and perimeter leads to errors in laydown on following layer
#15
@bubnikv
Copy link
Collaborator

bubnikv commented Nov 8, 2016

Fixed in 22ca927

The bridging has been broken, when I tried to fix the bridging for close regions. Now the bridging should work for both single and multiple touching regions.

@bubnikv bubnikv closed this as completed Nov 8, 2016
@mgineer85
Copy link
Author

thank you for your effort in this (single+multiple), will try again

@mgineer85
Copy link
Author

Thank you for building a new release and adding further information on how to build, I didn't get it right.
Just tried the new version, looks better now, but still not perfect in every case.
bridging_layerminus1
Bridges in different isles get the same angle though not touching and separated by perimeters.
bridging_layer

@bubnikv bubnikv reopened this Nov 8, 2016
@bubnikv
Copy link
Collaborator

bubnikv commented Nov 8, 2016

Would you please attach the models? Thanks.

@mgineer85
Copy link
Author

Uploading ZIPs with Firefox to github seems to be broken, otherwise I would have already.
Uploaded the models externally: https://oc.groene.de/index.php/s/c5kl7htxKlBesTE

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 8, 2016

Thanks for very good test cases. For the current code the bridging regions are connected. I am on a good way to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants