Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when trying to disable variable layer height feature #116

Closed
CReimer opened this issue Feb 10, 2017 · 11 comments
Closed

Crashes when trying to disable variable layer height feature #116

CReimer opened this issue Feb 10, 2017 · 11 comments
Labels

Comments

@CReimer
Copy link

CReimer commented Feb 10, 2017

Version

1.33.3

Operating system type + version

Arch Linux

I tried to disable the variable layer height feature, as it has no real use to me without an automatic mode.

When I try to disable the variable layer height feature Slic3r crashes.
When I disable it in the config Slic3r refuses to load the config file with the following error:

"I was unable to load the selected config file: Can't call method "Disable" on an undefined value at /usr/share/perl5/vendor_perl/Slic3r/GUI/Plater.pm line 1639."

@bubnikv
Copy link
Collaborator

bubnikv commented Feb 10, 2017

Thanks for the report. I did not test on Linux. It seems to be some kind of race condition specific to Linux.

By the way, why is the manual layer height of no use to you? Did you find any of the automatic layer height generators useful? On which models?

@CReimer
Copy link
Author

CReimer commented Feb 10, 2017

Actually I never tried these generators. I just assumed they do everything on their own and I don't have to worry about it. This sounds a bit like they don't do that?

@bubnikv
Copy link
Collaborator

bubnikv commented Feb 11, 2017

I just assumed they do everything on their own and I don't have to worry about it. This sounds a bit like they don't do that?

They do that, but for all but the simplest geometries they produce something you don't want. Namely, often the profiles are jagged and often they find a triangle in each layer, which dictates the thinnest layer allowed. I have addressed that in my release notes.

It is much more complicated to do the automatic variable layer height right. For example, you don't want to have too thin layers on overhangs, you don't want the thin layers to be triggered by features which are not visible, you want the transitions to be smooth etc. My implementation of the preview makes it easy to achieve nice surfaces of prominent features of complex models, for example of the Benchy's roof.

@bubnikv
Copy link
Collaborator

bubnikv commented Feb 11, 2017

I can reproduce the crash with our Linux binaries and the ArchLinux in the VirtualBox.

@bubnikv
Copy link
Collaborator

bubnikv commented Feb 11, 2017

A different toolbar type is used on WIndows than on OSX & Linux. Some of the code for OSX & Linux is missing. I will fix that. Thanks for a bug report.

@bubnikv bubnikv added the bug label Feb 11, 2017
@bubnikv
Copy link
Collaborator

bubnikv commented Feb 12, 2017

I just verified that it crashes the same way on OSX.

bubnikv added a commit that referenced this issue Feb 13, 2017
Enabling / disabling of the layer editing button on OSX & linux did not work.
@Wurstnase
Copy link

I just compiled the latest verions but I get:

Use of uninitialized value in subroutine entry at /home/nico/Tools/Slic3r_Prusa/lib/Slic3r/GUI/Plater.pm line 167.
Can't locate object method "variable_layer_height" via package "Slic3r::Config" at /home/nico/Tools/Slic3r_Prusa/lib/Slic3r/GUI/Plater.pm line 1765.

when trying to execute it.

@bubnikv
Copy link
Collaborator

bubnikv commented Feb 13, 2017

I just compiled the latest verions but I get:

Most likely the C++ compilation did not go through and you are running the new Perl code against the old C++ code.

@Wurstnase
Copy link

Is there something like make clean?

@Wurstnase
Copy link

Ok. Got it to run. Only the first part is shown in the terminal.

Use of uninitialized value in subroutine entry at /home/nico/Tools/Slic3r_Prusa/lib/Slic3r/GUI/Plater.pm line 167.

But it starts.

I had the old starting script from alexrj eval $(perl -Mlocal::lib). Without everything is ok again.

@bubnikv
Copy link
Collaborator

bubnikv commented Feb 15, 2017

Fixed by fd54956

@bubnikv bubnikv closed this as completed Feb 15, 2017
Jebtrix pushed a commit to Jebtrix/PrusaSlicer that referenced this issue Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants