Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estimated printing time error #10578

Closed
1 of 2 tasks
riccalisci opened this issue May 16, 2023 · 9 comments
Closed
1 of 2 tasks

estimated printing time error #10578

riccalisci opened this issue May 16, 2023 · 9 comments
Labels

Comments

@riccalisci
Copy link

Description of the bug

when in filament overrides there ise't value on detretraction and retraction value, estimated printing time give a same negative big value. Otherwise everything works

estimated time
filament setting

Project file & How to reproduce

-uncheck retraction and/or deretraction in filament overrides
-click on "slice now"

Checklist of files included above

  • Project file
  • Screenshot

Version of PrusaSlicer

2.6 beta 1

Operating system

windows 11

Printer model

Flsun Q5

@enricoturri1966
Copy link
Collaborator

@riccalisci
Could you please share the 3mf you are using to be sure to repro with the proper settings ?

@riccalisci
Copy link
Author

I used the bunny in shape gallery, but in everything shape that's I used found same problem.

@enricoturri1966
Copy link
Collaborator

I am not talking about the model, but about the config settings (printer, filament, ...).
I am unable to repro with the settings I usually use.

@riccalisci
Copy link
Author

bunny.zip

@enricoturri1966
Copy link
Collaborator

Thank you, now I can reproduce the issue

@bubnikv
Copy link
Collaborator

bubnikv commented May 16, 2023

In case the filament override value is not defined (disabled with the check box), one should not access the variable from the script.
In PrusaSlicer 2.6.0-beta1 a new function is available: is_nil(variable_name), which returns true in case the checkbox is off. In that case one shall use the value defined at printer profile.

We should however extend PrusaSlicer to give an error in case a nil value is accessed.

@Jan-Soustruznik
Copy link
Collaborator

Issue created SPE-1710

@bubnikv
Copy link
Collaborator

bubnikv commented May 18, 2023

PrusaSlicer 2.6.0-beta3 will display the following error message and stop G-code export with your start & end custom G-codes:

image

You should use retract_speed[0] instead of filament_retract_speed[0] in case is_nil(filament_retract_speed[0]) is true.

You may find the following useful for working with such complex expressions as above:
https://github.com/prusa3d/PrusaSlicer/wiki/PrusaSlicer-Macro-Language#custom-variables-4048-7196

@bubnikv
Copy link
Collaborator

bubnikv commented May 18, 2023

Fixed with c21e745

@bubnikv bubnikv closed this as completed May 18, 2023
lukasmatena pushed a commit that referenced this issue May 26, 2023
and throw if such nil variable or vector element is used.
Fix of #10578 SPE-1710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants