-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++14 issues #1
Comments
Also, I should mention that the code builds fine with the same compiler with the |
Thank you. I am developing mainly on Visual Studio 2013 and the builds are built on Strawberry Perl and on MacOS, where the C++14 features are disabled. I shall disable the C++14 optimizations for now, before the issues get cleared. |
Yes, please, we will be thankful for pull requests. |
@bubnikv Alright, I shall create a PR where I incrementally add the fixes. At least I'll be able to fix the most evident mistakes, but the other stuff might take some time. I'll close this issue for now. |
Reopening to make this better discoverable by those having similar problems. |
…ts-logic Added test for enforced support generation.
Compiling from master @ 36f51ff yields quite a many compilation errors with a recent
gcc
(version 6.2.1) on Linux due to errors in code in#ifdef SLIC3R_CPP > 11
blocks. The defaultC++
standard for recentgcc
isC++14
(more precisely-std=gnu++14
which contains GNU extensions). The errors are especially related to rvalue reference overloaded functions in e.g.PolylineCollection.cpp
(chained_path
andchained_path_from
).Are you accepting contributions to your fork? I might start slowly looking at these in order to make it build on more recent compilers and take advantage of the move semantics.
The text was updated successfully, but these errors were encountered: