Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFW-1204: M600 - Show filament name at the Insert filament prompt #4759

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Panayiotis-git
Copy link
Contributor

This PR is an upgraded version of the #2380.

It introduces the C parameter that defines the filament name to be displayed at the Insert filament and Loading filament messages. The filament name must be enclosed in double quotes.

The new syntax is:
M600 X[pos] Y[pos] Z[relative lift] E[initial retract] L[later retract distance for removal] C"[filament name to show during loading]"

For example, the command:
M600 C"Electric Blue"

will show the message:

Insert filament
Electric Blue
and press the knob

and afterwards:

Loading filament
Electric Blue
Please wait
....

Copy link

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 164 0 247900 5653 6052 2539
MK3_MULTILANG 148 0 247198 5662 6754 2530

@3d-gussner 3d-gussner added this to the FW 3.14.1 milestone Aug 22, 2024
@3d-gussner 3d-gussner changed the title M600 - Show filament name at the Insert filament prompt PFW-1204: M600 - Show filament name at the Insert filament prompt Aug 22, 2024
Copy link
Collaborator

@3d-gussner 3d-gussner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as described 🥇

I sliced a small tower with two M600 changes, one without the new C"<String>" parameter and the second one with the new parameter. An additional gcode with a too long C String has been used to verify that the LCD screen doesn't mess up.

Tests on MK404

  • MK3S normal
    • first M600 behaves the same as usual
    • second M600 C"Electric Blue" asks and shows correctly that string on LCD screen
    • Too long string M600 C"Prusament PLA GalaxyBlack" is cut to 20 chars and shown on LCD correctly as Prusament PLA Galaxy
  • MK3S + MMU3 in Single mode
    • first M600 behaves the same as usual
    • second M600 C"Electric Blue" asks and shows correctly that string on LCD screen
    • Too long string M600 C"Prusament PLA GalaxyBlack" is cut to 20 chars and shown on LCD correctly as Prusament PLA Galaxy
  • MK3S + MMU3
    • The C"<String>" parameter isn't shown on LCD as in full MMU mode the user is asked during a M600 to load one of the five filaments.

@3d-gussner
Copy link
Collaborator

3d-gussner commented Aug 22, 2024

@Panayiotis-git Thank you very very much for the 4th PR related to this feature and sorry for the additional work you had to put into this PR.

Here few screen shots:
Thu Aug 22 06:45:23 2024

Thu Aug 22 06:45:26 2024

Thu Aug 22 06:55:00 2024

Copy link
Collaborator

@gudnimg gudnimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@3d-gussner 3d-gussner merged commit 2f7715a into prusa3d:MK3 Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants