optimisation: simplify two LCD messages #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
gudnimg
commented
Oct 21, 2023
There is no need to restrict how often the message is rendered. It was being restricted to render every 1 second. We don't do this for most of the static menus. So I propose this 1 second period be removed. Tested on MK3S+ Change in memory: Flash: -168 bytes SRAM: -8 bytes
gudnimg
force-pushed
the
lcd-opt-message
branch
from
f8b8aa7 to
469f002
Compare
3d-gussner
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to restrict how often the message is rendered. It was being restricted to render every 1 second. We don't do this for most of the static menus. So I propose this 1 second period be removed.
Tested on MK3S+
Change in memory:
Flash: -168 bytes
SRAM: -8 bytes