mmu: Don't log Query (Q0) requests/responses when MMU is Idle #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Query is running in Idle state machine, then don't log anything. But still allow asynchronous requests to be logged. For example a register read via M707. This makes the serial log muuch cleaner when the MMU is idle.
|
All values in bytes. Δ Delta to base
|
|
Closing this PR since it won't be merged. I will keep the branch open though since it may be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea I have to resolve #4414
If a Query is running in Idle state machine, then don't log anything but still allow asynchronous requests/responses to be logged. For example a register read via M707 will still show up fine.
This makes the serial log muuch cleaner when the MMU is idle. When running a printjob, it is only when a command such as toolchange is running that everything will be logged again.