Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFW-1542 Don't allow starting SD print if there is a thermal or fan error #4449

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

gudnimg
Copy link
Collaborator

@gudnimg gudnimg commented Oct 15, 2023

Two small fixes:

  • Don't allow starting SD print if there is a thermal or fan error. Here I am reusing the exact same conditions which are applied to "Resume print" feature.
  • Reset the status line message when the fan error is resolved automatically to show "Prusa i3 MK3S OK" instead of "Err:HOTEND FAN ERROR"

Steps to reproduce issue:

  1. Start a print
  2. Once the purge line is started to extrude => block the hotend fan until error appears
  3. Print is paused due to fan error (note that the print can’t be resumed)
  4. Keep blocking the fan and stop the print
  5. Observe issue: A new print can be started even if the fan error is still active/unresolved.

Apply same conditions as on "Resume print" feature.
Starting a SD print should not be possible if there is an active hardware error
If the error is really resolved, I'd prefer to see

"Prusa i3 MK3S OK" instead of "Err:HOTEND FAN ERROR"
@gudnimg gudnimg added this to the FW 3.13.2 milestone Oct 15, 2023
@gudnimg gudnimg requested review from 3d-gussner and DRracer October 15, 2023 12:32
@github-actions
Copy link

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 24 0 246022 5633 7930 2559
MK3_MULTILANG 24 0 245308 5642 8644 2550

Copy link
Collaborator

@3d-gussner 3d-gussner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test results from #4450
Tested on MK404

  1. Stall fan
  2. Start SD print
  3. 65~ish Err:HOTEND FAN ERROR detected ✔️
  4. Resume fan --> Resume menu ✔️
  5. Stall fan --> Err:HOTEND FAN ERROR ✔️
  6. Again and again these steps ✔️

2nd test

  1. Stall fan
  2. Start SD print
  3. 65~ish Err:HOTEND FAN ERROR detected ✔️
  4. Stop print
  5. Err:HOTEND FAN ERROR
  6. Limited menu without Print SD ✔️
    1. But it times out and is shown even
      1. Fan is still stalled
      2. Fan check isn't disabled
      3. Good is that the next Print from SD errors out correctly with stalled fan ✔️
    2. Settings -> Fancheck [Off] works well
  7. With Fan check [Off] and stalled fan the print starts ✔️
    1. As soon I turn on in Tune -> Fan check [On] it errors out correctly ✔️

@3d-gussner 3d-gussner merged commit fa056ce into prusa3d:MK3 Oct 16, 2023
5 checks passed
@gudnimg gudnimg deleted the PFW-1542-v3 branch September 1, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants