Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Spanish diacritics #4440

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Update Spanish diacritics #4440

merged 4 commits into from
Oct 17, 2023

Conversation

3d-gussner
Copy link
Collaborator

No description provided.

@3d-gussner 3d-gussner added the translations language packages label Oct 11, 2023
@3d-gussner 3d-gussner added this to the FW 3.14.0 milestone Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG -40 0 245982 5633 7970 2559
MK3_MULTILANG -30 0 245278 5642 8674 2550

@leptun leptun changed the title Update Spanish dicaritics Update Spanish diacritics Oct 11, 2023
leptun
leptun approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@leptun leptun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language seems to build correctly from PO files. I removed the ñ symbol from the FontTable since it's unused.

@leptun leptun mentioned this pull request Oct 11, 2023
Merged
1 task
@3d-gussner
Copy link
Collaborator Author

I will update the changes suggested by @misan tomorrow morning. 🤗

@leptun
Copy link
Collaborator

leptun commented Oct 13, 2023

If it includes ñ characters, let me know and I'll drop the fontTable commit

@3d-gussner
Copy link
Collaborator Author

Here the output of all Spanish messages
ES.txt

@3d-gussner @leptun
Updates by @misan
07b7842 
Some minor changes for better fit on LCD
@leptun
Copy link
Collaborator

leptun commented Oct 14, 2023

@3d-gussner I've dropped that commit since I think it would be better if I prepared a single PR with all the FontTable changes.

@3d-gussner
Copy link
Collaborator Author

@leptun Okay, just wondered why my last changes failed to push.

@3d-gussner 3d-gussner mentioned this pull request Oct 17, 2023
Merged
@3d-gussner 3d-gussner merged commit 323f9aa into prusa3d:MK3 Oct 17, 2023
@3d-gussner 3d-gussner deleted the MK3_Spanish branch October 17, 2023 13:15
@3d-gussner
Copy link
Collaborator Author

See video #3383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leptun leptun leptun approved these changes

Assignees
No one assigned
Labels
translations language packages
Projects
None yet
Milestone
FW 3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@3d-gussner @leptun