PFW-1542 Fix an issue where print can't be stopped under specific circumstances #4403
Conversation
There is a bug where if the printer is recovering a print, it run a blocking loop to restore the extruder and bed temperatures. But if a Fan error is triggered in this loop, then the user can't abort the print via LCD. If the fan error resolves on its own the 'Resume print' menu will appear in a few seconds. But if not, then the user can't resume the print (which is normal). But with the bug above the user can't abort the print either! The problem is essentially isPrintPaused variable is cleared too early. We should wait until the print is completely restored first. Steps to reproduce: 1. Start a print 2. Pause the print 3. Wait for extruder temperature to fall at lest 180°C 4. Click 'Resume' print 5. While heating, stop the hotend fan and wait for a few seconds until an error is raised 6. Observe issue => 'Stop print' menu item is gone! PFW-1542
|
|
@3d-gussner I think this fixes a lot of inconsistencies with the menus. For example I suspect we don't need this change anymore: 77a4b99 |
lcd_calibration_menu: Remove redundant if (!isPrintPaused). The menu is never called unless this condition is true. eeprom_switch_to_next_sheet: Don't show this menu if the printer is busy doing work! Do not allow these menus to run while a print is paused or when we're recovering a print: - Preload to MMU - Load to Nozzle - Unload filament - Eject from MMU - Cut filament - Autoload filament - Settings - Calibration
gudnimg
changed the title
|
@3d-gussner let me know if I should remove the menu changes (they are technically unrelated to the core issue blocking final 3.13.2 release). I only added them since you mentioned these menus shouldn't be available when resuming a print or when it's paused. I did try unloading filament during a pause and it behaves strangely. (With MMU btw) |
There was a problem hiding this comment.
Works well, tried really hard to BREAK it with multiple stall/resume stall while resuming multiple times. Always recovered correctly.
@gudnimg Please prepare a cherry-pick PR for MK_3.13.2 branch. Maybe only the fan fix without the 2nd part and menus.
ℹ️ This has been an issue since at least FW 3.9
There is a bug where if the printer is recovering a print, it will execute a blocking loop to restore the extruder and bed temperatures. But if a Fan error is triggered in this loop, then the user can't abort the print via LCD.
If the fan error resolves on its own the 'Resume print' menu will appear in a few seconds. But if not, then the user can't resume the print (which is normal). But with the bug above the user can't abort the print either!
The problem is essentially
isPrintPausedvariable is cleared too early. We should wait until the print is completely restored first.Steps to reproduce:
TODO:
PFW-1542