MBL: Add magnet compensation parameter #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sarusani
force-pushed
the
mbl_mag_comp
branch
from
5c77227 to
a144e3b
Compare
sarusani
changed the title
allow to enable/disable magnet compensation when 7x7 is in use.
sarusani
force-pushed
the
mbl_mag_comp
branch
from
a12ed34 to
21c57a1
Compare
gudnimg
reviewed
Sep 14, 2023
gudnimg
approved these changes
Sep 14, 2023
gudnimg
approved these changes
Sep 14, 2023
leptun
approved these changes
Sep 15, 2023
|
I feel the same way. I just wasn't able to come up with something else that remotely makes sense and doesn't clash with the other arguments. I was thinking about E for "elimination". But outside of the code, the feature is always referred to as "magnet compensation". |
sarusani
force-pushed
the
mbl_mag_comp
branch
from
0954bd5 to
84d3537
Compare
|
@sarusani Had to fix the merge conflict as I merged 4391 first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user selected 3x3 in the LCD menu he can't set if he wants to use magnet compensation or not. (It's only available for 7x7)
So I added a magnet compensation parameter (M). It is only in use if a 7x7 mesh bed leveling is performed.