Delay Z-Axis on Autoload #4280
Merged
Delay Z-Axis on Autoload #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudnimg
reviewed
Jul 25, 2023
|
Commit 26369ac made some code obsolete. The behavior is now consistent in all load cases (autoload, manual, gcode, mmu). If MIN_Z_FOR_LOAD is set, it will always raise the z-axis after the fast load sequence. |
|
All values in bytes. Δ Delta to base
|
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
6 times, most recently
from
eeab619 to
7af3906
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
3 times, most recently
from
40d7a0a to
c4409b8
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
3 times, most recently
from
69e4ce5 to
af19cf4
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
2 times, most recently
from
5d21f6b to
b4c8b87
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
2 times, most recently
from
ccd833d to
a984c7c
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
2 times, most recently
from
9d3bbd4 to
82ca402
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
from
82ca402 to
b371cb7
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
from
b371cb7 to
92b865d
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
from
92b865d to
b3d1b21
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
from
b3d1b21 to
1d2f427
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
from
1d2f427 to
aec53ce
Compare
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
from
aec53ce to
c364654
Compare
Delay z-axis movement when the operators hand is close to the printhead.
sarusani
force-pushed
the
DelayZAxisonAutoload
branch
from
c364654 to
5efae44
Compare
|
@gudnimg @sarusani is the #4280 (review) resolved if so please mark it as "resolved". |
Looked over the changes again and the PR looks good to me. I haven't tested the changes though. |
gudnimg
approved these changes
Jul 7, 2024
There was a problem hiding this comment.
Looks good to me. It would be nice to get another approval as well (@3d-gussner ?)
3d-gussner
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay z-axis movement when the operators hand is close to the printhead.
This is my proposed solution to resolve #4115.
The basic idea is to wait with z-axis movement until the user removed his hand from the printhead.
Instead of moving as soon as the filament sensor is triggered, the filament is first grabbed by "fast load" and after that the z-axis is moved up.
How to reproduce:
Original behavior: Printhead lifts Z position to MIN_Z_FOR_LOAD (50mm) as soon as filament sensor is triggered and then starts fast loading the filament.
New behavior: Printhead grabs filament with fast load and then moves Z axis up to MIN_Z_FOR_LOAD (50mm).