crashdet_cancel() doesnt cleanup all variables when USB printing
#4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudnimg
changed the title
crashdet_cancel() doesnt cleanup all variables when using USB printingcrashdet_cancel() doesnt cleanup all variables when USB printing
gudnimg
force-pushed
the
crashdet_cancel-fixup
branch
from
9593f50 to
9e78b13
Compare
|
I generally agree here, I think this has always been overlooked recently |
wavexx
previously requested changes
Jul 22, 2023
gudnimg
force-pushed
the
crashdet_cancel-fixup
branch
from
9e78b13 to
5faa0d0
Compare
|
All values in bytes. Δ Delta to base
|
|
I pushed another commit which optimizes setting the crash detection on or off. |
gudnimg
changed the title
crashdet_cancel() doesnt cleanup all variables when USB printingcrashdet_cancel() doesnt cleanup all variables when USB printing
|
Adding 🚧 to the title as this PR is not tested |
gudnimg
force-pushed
the
crashdet_cancel-fixup
branch
from
365ca48 to
5b4983a
Compare
I would think that this should behave similarly as when stopping the print via the LCD. Changed UnconditionalSto()p to not close the SD card file if we're using Octoprint. Then there shouldnt be any file open. Some of the variables which were not reset: isPrintPaused pause_time saved_start_position saved_printing_type Bed heater may be left on? Change in memory: Flash: -28 bytes SRAM: 0 bytes
Change in memory: Flash: -6 bytes SRAM: 0 bytes
Add function crashdet_use_eeprom_setting Change in memory: Flash: -52 bytes SRAM: 0 bytes
gudnimg
force-pushed
the
crashdet_cancel-fixup
branch
from
5b4983a to
e1e0b0a
Compare
3d-gussner
requested changes
Nov 30, 2023
3d-gussner
changed the title
crashdet_cancel() doesnt cleanup all variables when USB printingcrashdet_cancel() doesnt cleanup all variables when USB printing
3d-gussner
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function doesn't look correct to me 🤔 I would think that this should behave similarly as when stopping the print via the LCD. This PR is my proposed improvement, un-tested at the moment.
Changed
UnconditionalStop()to not close the SD card file if we're using Octoprint. Then there shouldnt be any file open.Some of the variables which were not reset:
isPrintPausedpause_timesaved_start_positionsaved_printing_typeIt seems like the bed heater could also be left enabled?
Fixes #4324
Change in memory:
Flash: -28 bytes
SRAM: 0 bytes