Implement M204 T (separate travel acceleration) #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm thinking now that the current travel acceleration also needs to be saved in eeprom during a power-panic, something which is currently missing here. |
wavexx
force-pushed
the
m204_travel_acceleration
branch
from
d362a18 to
3840fe3
Compare
|
PR should be complete now. Rebased on top of the current master in order to handle new EEPROM offsets without conflicts. In the last commit I handle all acceleration settings (not just travel acceleration) during UVLO, which were completely skipped before. Saving and restoring is not 100% correct with this PR, although is better than nothing. See comments on 3840fe3 for details. This needs to be handled correctly by saving/restore more limits in the future. |
Allow to separate extrusion and travel acceleration settings using M204, as Marlin 1.1.x and 2.x does using M204 T. This allows to reduce the number of instructions required during printing, since resetting the acceleration for travel moves is no longer required and can be done a single time during the print. Provision for this parameter was pre-existing, but not implemented. M204 has two forms: the lagacy format (Marlin <1.1): M204 S[print-acc] T[retract-acc] and the newer format: M204 P[print-acc] R[retract-acc] T[travel-acc] The distinction in the MK3 FW is done based on the presence of the P parameter. If P is seen, the new format is adoped. In the new format however, M204 T was ignored until this change. To keep backward compatibility, M204 S[acc] will set both print and travel acceleration, which is identical in behavior to recent versions of Marlin.
Use the same value as DEFAULT_ACCELERATION for compatibility.
When reading uninitialized memory, preset the travel acceleration to be the same as the default acceleration.
Save some space and perform some cleanup
Use the new M204 format consistently also in M503's output
Acceleration settings need to be saved in UVLO, since these are often changed/set during a print. This is especially important for travel and retract acceleration, which is usually set once per-print. Saving and restoring is not 100% correct. We save the current front-end value, which might ahead of the backend when UVLO is triggered. Print acceleration, likely the most significant, should be saved in the block buffer to be accurate. Acceleration needs to be restored after the UVLO Z repositioning is performed, using an M204 command. This is correct, however we don't save the _temporary_ max acceleration limits set via M201, which could be higher than the saved limits (via M500). This could result in lower clamped values compared to the original print. Maximum acceleration/jerk/feedrate limits should _all_ be saved in UVLO in the future.
wavexx
force-pushed
the
m204_travel_acceleration
branch
from
3840fe3 to
186ce0f
Compare
DRracer
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to separate extrusion and travel acceleration settings using M204, as Marlin 1.1.x and 2.x does using
M204 T.This allows to reduce the number of instructions required during printing, since resetting the acceleration just for travel moves is no longer required and can be done a single time during the print.
Provision for this parameter was pre-existing, but not implemented.
M204 has two forms: the lagacy format (Marlin <1.1):
and the newer format:
The distinction in the MK3 FW is done based on the presence of the
Pparameter. IfPis seen, the new format is already used.In the new format however,
M204 Twas ignored until this change.To keep backward compatibility,
M204 S[acc]will set both print and travel acceleration, which is identical in behavior to recent versions of Marlin.M500 and M503 will report settings using the "new format". A new field in the EEPROM is stored for the travel acceleration, and is initialized with the same value as the print acceleration. The initial default from a fresh eeprom is defined in the variant file, and again it is set to the same value.