#2464 fix runout for unknown filament (also fixes #1993, #2301) #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with upstream
Fix runout if filament is unknown
vintagepc
changed the title
|
Just noting that I encountered another test case for this today - Unknown slot, ran out of filament mid print as I was using up leftovers. Functioned perfectly - unloaded old filament, I was able to move the selector to a new slot with MMU buttons (it rehomed as expected), and push the button to confirm - it loaded and continued printing happily. |
DRracer
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the printer soft-resetting if a filament runout is detected while the current filament is unknown (e.g. user loaded to nozzle, and an event caused a power cycle (power panic during MMU print), or user turned off printer and continued printing with the same filament the next day).
Because the current filament is unknown, we cannot reliably retract it and move on to the next one if spooljoin is enabled (theoretically we could try this and let the MMU try a retract/home/next filament, but that seems risky), nor can we mark it as depleted.
Therefore, we just do a normal M600 requiring user attention, do not mark it as depleted, nor try to continue with spooljoin.
This fixes #2464, fixes #1993, and fixes #2301
Update: should also fix #2500
PFW-1100