Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFW-5918] gui: don't remove trailing zeroes of the Footer's axis value #4129

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

puhitaku
Copy link
Contributor

@puhitaku puhitaku commented Aug 8, 2024

This PR implements the enhancement I proposed in #4042 . I confirmed it works as expected on my Prusa MK4.
I set master as the base branch since other PRs do this. Please switch this if necessary. Thank you!

Changes

  • src/gui/footer/footer_item_axis.hpp, footer_item_live_z.cpp: else-if blocks are removed to stop removing trailing zeroes after the decimal point.

Fixes

  • Added setuptools to the Holly's dependency
    • Since Python 3.12.3, venv won't pre-install setuptools
    • I used Python 3.12.3 to build the firmware and suffered an error due to the lack of it

@danopernis danopernis changed the title gui: don't remove trailing zeroes of the Footer's axis value [BFW-5918] gui: don't remove trailing zeroes of the Footer's axis value Aug 14, 2024
@danopernis danopernis force-pushed the puhitaku/footer-digits branch from 6b18f28 to 56ff0b3 Compare August 14, 2024 05:40
Copy link
Member

@danopernis danopernis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I rebased it onto current master branch, turns out we already have the setuptools patch.

@danopernis danopernis merged commit d8d5ec6 into prusa3d:master Aug 14, 2024
1 check passed
@puhitaku puhitaku deleted the puhitaku/footer-digits branch August 21, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants