Update fast nozzle cooling #4014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have consent from the user right now and they are not encrypted. Shouldn't go to "production". BFW-3468.
…sure getting the filament out of the gear)
Dialog stores the state of underlying screen upon construction and loads it back upon destruction. Consistently. Like, always. Without this, ToolBox::DialogToolActionBox would set focused item which would prevent menu screen from serializing its focused item.
Allow them in redscreen/redscreen. It's already sent proactively, so it's safe. BFW-5207.
Show Enclosure menu only if enclosure is active Change string describing invalid temperature from "N/A" to "--"
Transfers were not cleaned up ever, if in print preview when finished, this was caused by wrongly detecting if the transfer is in progress. It did not check, if the backup file was there, do transfer, where backup file was not present (finished) were taken as in progress.
…sensor_and_user_push__ask BFW-5361
This reverts commit f605a28bea662f02ec8d5121f4f57cee8ada774b.
BFW-5297
Copy pasted from standard printing screen BFW-5371
BFW-5373
Use same settings as we have in the 8-bit firmware see [here](https://github.com/prusa3d/Prusa-Firmware/blob/MK3/.github/workflows/stale.yml)
Fast nozzle cooling used 'F' parameter in M109 but this collides with Marlin FW so 'C' should be used (as reserved in https://reprap.org/wiki/G-code)
|
This will break existing gcodes. What problem are you trying to solve? |
|
I've created and implemented that parameter but I've used already used parameter. So I've changed it to C. I'm not sure why it's back. Also people don't use it because it was not promoted. |
|
@danopernis he used the wrong flag in this commit. It should be fixed in order to reflect the official documentation here , which states that 'C' should be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast nozzle cooling used 'F' parameter in M109 but this collides with Marlin FW so 'C' should be used (as reserved in https://reprap.org/wiki/G-code)