Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcode: m23 send serial msg on file select for octoprint / add missing M32 gcode cmd #3766

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

bkerler
Copy link
Contributor

@bkerler bkerler commented Feb 18, 2024

This addresses issue #3748 and adds a serial message that the file has been selected for octoprint.
Also implements missing m32 gcode command.

@arekm
Copy link

arekm commented Feb 18, 2024

and #2387

@danopernis danopernis self-requested a review February 26, 2024 09:39
Copy link
Member

@danopernis danopernis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, please just add the usual comment about why we need SERIAL_ECHO there...

@bkerler
Copy link
Contributor Author

bkerler commented Feb 29, 2024

Done, added the comment :)

@bkerler bkerler requested a review from danopernis February 29, 2024 19:28
@danopernis danopernis merged commit 94a5daa into prusa3d:master Mar 5, 2024
1 check passed
@bkerler bkerler deleted the m23_selected branch March 5, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants