-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BFW-5926] Enable DNS for sntp and set default to prusa3d.pool.ntp.org #3730
Conversation
830125f
to
cbc9035
Compare
The NTP pool service doesn't allow people to use pool.ntp.org as a default, the vendor (Prusa) must ask for a custom name. See https://www.ntppool.org/en/vendors.html#basic-guidelines |
Yes, they do request you not use the default pool if you are a vendor. However, you can easily request and use a 'prusa' vendor pool (prusa.pool.ntp.org) and use that instead. It is better than the current hard-wired Czech CESNET NTP server and one will get better geographic locality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good news everyone, NTP pool approved our request for vendor zone 🥳
@thess can you please use prusa3d.pool.ntp.org
?
Also, this needs to be rebased onto current master. If you have difficulties with that, I can try rebasing in your fork, if I have the correct permissions.
Edit: I see there is also open #3679 by @bkerler
Can you folks please remind me what those two PRs were about? There seems to be more discussion in #3679 so maybe we should close this as a duplicate?
@danopernis this one is just enabling dns for sntp and enables ip pooling via pool.ntp.org. #3679 however is including this but does also enhance more, such as setting the dns ip manually instead of hardcoding, dns v6 support preparation and setting ntp via dns server. #3679 was also already reviewed by @vorner but is stalling right now. |
@danopernis - glad to hear you got a Prusa3D NTP pool zone. I have made the requested change and have rebased the PR to the |
Not sure what this CI failure is about -- nothing in my PR deals with this.
Edit: Error indicates a cpython API compatibility problem between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thess thanks, I am merging this. Sorry for the inconveniences due to rebasing.
This PR changes the default behavior of the SNTP client to use DNS name resolution for an NTP server target. The main advantage is load-balancing servers by using NTP server pools (eg:
pool.ntp.org
) which rotate addresses periodically via DNS. Another reason is the DNS query response from the pool is distributed by geography of requester as well.I think this change and #3679 are complimentary - both are desired.
Ref: https://www.ntppool.org/