[BFW-5626] Support quoted INI string values #3158
Conversation
|
I see now this parser is actually a copy of https://github.com/benhoyt/inih, which attempts to align with a Python behavior as noted in this interesting report: It would be ideal if this was supported, so please give this PR some consideration. Otherwise, I guess the ultimate solution to my goals is to support BSSID specification, which I'm happy to add instead, but would like to know the status of this comment first: #2325 (comment) |
nmschulte
force-pushed
the
nms/ini-quoted-string-values
branch
from
2592bd7 to
2344682
Compare
|
bump -- @dragomirecky, et al |
|
Bump. |
1 similar comment
|
Bump. |
|
Adding my use case in that I am dealing with a long-existing Wi-Fi network having a PSK that ends in a space, which is allowed in the Wi-Fi specifications. Would love to see this PR considered as a solution. |
There was a problem hiding this comment.
@nmschulte sorry for taking so long. Thanks for the patch and also for the digging of related issues in INIH parser, it is interesting reading indeed. Your code seems to be almost working, so let's fix the special case and hopefully get this merged.
nmschulte
force-pushed
the
nms/ini-quoted-string-values
branch
from
2344682 to
c6a5cbc
Compare
danopernis
changed the title
Support singly and doubly quoted INI strings, e.g. leading and trailing spaces in WiFi SSID/PSK field values.
danopernis
force-pushed
the
nms/ini-quoted-string-values
branch
from
84162e2 to
8a18b05
Compare
There was a problem hiding this comment.
@nmschulte I rebased it onto current master and adjusted it so that the diff is minimal. Thanks for your contribution.
support singly and doubly quoted INI strings, for e.g. leading and trailing spaces in WiFi SSID/PSK field values
addresses #2325