Add M117 support (print progress with octoprint) #1497
Conversation
|
A few notes on the legal side:
|
|
Thank you both for the feedback. I have made the following changes:
@matthewlloyd: I hope it is clear my intent was not to usurp your work, which is why I mentioned in the PR's comments where the code comes from (your Llama firmware repo). I just didn't think to set the author on the commits to you. I apologize for that, and I believe I have now resolved that issue properly. edit: and it still doesn't build. I can't see why since I haven't got access to holly.prusa3d.com |
|
@coaxial you can run the test build yourself to see what is failing, which is much quicker. The file utils/holly/build-pr.jenkins contains the actual recipe being used for testing. It simply runs ctest appropriately. If you have a linux env, you can do: from the source directory to create the "build-test" directory and run the tests inside that in one shot. |
coaxial
force-pushed
the
RELEASE-4.3.2
branch
from
193843d to
97904ac
Compare
|
When running Note I have rebased this on |
|
@DRracer please advise |
|
It looks like there is some problem with compiling your code. This is the error. |
|
Thank you, I've added the missing include for that entity. The build is still failing. I tried building it locally with I really wish I could see the Holly build system's output without granting it access to all my public and private repos. [0]: |
|
It seem like you have some problems with build. Try to build the firmware with the bundled build.py script. |
|
@MistrKernnunos Thanks. I tried building it locally but it simply fails without any explanation or context: |
|
Try to rebase the branch on current master and you should get newer version of build system which is based on CMake presets. And the use something like this or |
|
I am burnt out working on this issue, I just don't have the time or bandwidth to deal with it. I also don't know C enough to solve the current build issues. I still think it's a glaring omission in the firmware for a printer that is marketed "for print farms", yet doesn't support the standard set of GCode for printing over serial 3 years after release... If anyone wants to look into it here is what's left to do:
Using https://github.com/matthewlloyd/Llama-Mini-Firmware for reference, although I think the two repos have diverged quite a bit. |
|
Is it planned or not? Because many users want this and maybe Prussa tema could take look :) |
@coaxial I know this is a year on, but I ran into a similar thing in the past, I just created a second "Fully Public" account that it was fine for systems like Holly to hit. It's a bit of a crude workaround, but it does work. |
|
Thanks for the tip. I don't have the bandwidth to work on this anymore, and it would most likely need to be rebased on the current If anyone feels like taking this on, it would be nice. Maybe even @josefprusa themselves could finally add this sorely missing feature to the Mini. |
|
@coaxial I was able to rebase this and get it building (excluding some probably flaky pre-commit issue), could you help me test it? I'm waiting on my mk4 because of lead-times. #3147 |
|
@Monkopedia Nice! I don't have access to holly.prusa3d.com because it demands access to all public and private repos to access it... Which I won't allow. Also, I own a Mini which requires physical, irreversible damage to flash custom firmware onto. As such, I'm limited to official firmware only :/ |
|
@coaxial What should be done to get this PR moving again? Is it still relevant? Should it be closed instead? |
|
This is not going to be merged, for several reasons
Closing this. |
This shows the print progress on the Mini's LCD when printing through Octoprint.
A few notes:
src/gui/window_lcd_message.cppsince this file didn't exist in this codebase and comes straight from the Llama Mini Firmware projectHopefully this can be merged and be part of the next release.
Closes #189.
edit: I can't see why it doesn't build, because to access holly.prusa3d.com I have to give access to all my repos (public and private)... I'd rather not.