Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

[DCS Patch 3/5] port dynamic channel selection from rdkb task #644

Merged
merged 5 commits into from
Jan 20, 2020
Merged

[DCS Patch 3/5] port dynamic channel selection from rdkb task #644

merged 5 commits into from
Jan 20, 2020

Conversation

itayx
Copy link
Collaborator

@itayx itayx commented Jan 6, 2020 •
edited by kantera800
Loading

The Dynamic Channel Selection as a feature can provide information on the supported channels which can be utilized by the management system to provide better availability and user experience.
#562

The Dynamic Channel Selection feature is divided into several pull request, this is the third out of 5
start review from 676ac83

Dynamic Channel Selection Task:

Changes in this PR include the following:

  • controller: task: add clear pending events
  • controller: dymanic channel selection task intro
  • controller: DCS task: FSM
  • controller: DCS task: events
  • controller: DCS task: node & DB

@kantera800 kantera800 mentioned this pull request Jan 6, 2020
Closed
8 tasks
@itayx itayx force-pushed the feature/port-dynamic-channel-selection-from-rdkb-task branch from bc0826a to 9dbf162 Compare January 7, 2020 13:10
@itayx itayx mentioned this pull request Jan 8, 2020
Closed
@itayx itayx marked this pull request as ready for review January 8, 2020 13:54
@itayx itayx force-pushed the feature/port-dynamic-channel-selection-from-rdkb-task branch from 9dbf162 to 27612c8 Compare January 8, 2020 14:19
@kantera800 kantera800 changed the title Feature/port dynamic channel selection from rdkb task [DCS Patch 3/5] port dynamic channel selection from rdkb task Jan 8, 2020
tomereli
tomereli suggested changes Jan 9, 2020
View reviewed changes
controller/src/beerocks/master/tasks/task.cpp Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.h Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.h Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Show resolved Hide resolved
vitalybu
vitalybu suggested changes Jan 9, 2020
View reviewed changes
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.h Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.h Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp
// Before sending the request set the scan_in_progress flag to true
// So another scan would not trigger on the same radio simultaneously

database.set_channel_scan_in_progress(m_radio_mac, true, m_is_single_scan);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we store this in the database? Is it accessed from additional places?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we cannot allow user to trigger chan scan on the same radio in the middle of a already running scan

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if can read task fsm state instead #665

@kantera800
Copy link
Collaborator

[DCS Patch 3/5]Port dynamic channel selection

@kantera800 kantera800 force-pushed the feature/port-dynamic-channel-selection-from-rdkb-task branch 4 times, most recently from 391b30c to 0ce6f74 Compare January 17, 2020 02:09
@kantera800
Copy link
Collaborator

ready for re-review:

fixed all code review issues.
rebased to patch 2/5

@ghost ghost assigned itayx Jan 17, 2020
tomereli
tomereli approved these changes Jan 19, 2020
View reviewed changes
common/beerocks/bcl/include/bcl/beerocks_defines.h Outdated
@@ -443,6 +447,30 @@ enum eBssType {
BSS_TYPE_INVALID
};

enum class eChannelScanErrCode : uint8_t {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since its an enum class, there is no need to have the CHANNEL_SCAN_ prefix

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#665

controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.h Outdated Show resolved Hide resolved
controller/src/beerocks/master/tasks/dynamic_channel_selection_task.cpp Outdated Show resolved Hide resolved
@itayx itayx force-pushed the feature/port-dynamic-channel-selection-from-rdkb-task branch 2 times, most recently from b4505ea to bf27c05 Compare January 19, 2020 20:51
@kantera800 kantera800 force-pushed the feature/port-dynamic-channel-selection-from-rdkb-task branch 2 times, most recently from 3738c0b to 39ac50e Compare January 20, 2020 07:06
@itayx itayx force-pushed the feature/port-dynamic-channel-selection-from-rdkb-task branch from 39ac50e to c241cf6 Compare January 20, 2020 09:37
@kantera800 kantera800 force-pushed the feature/port-dynamic-channel-selection-from-rdkb-task branch 2 times, most recently from bcd3280 to 5cc493c Compare January 20, 2020 12:08
itayx added 5 commits January 20, 2020 15:03
@itayx
controller: tasks: clear pending events
936a989 
This is a preparative commit for "DCS task: Events".

We need to clear all task events in case of an error that
will prevent unnesesary event handling and error log prints.
Adding  clear_pending_events method to the task base class.

Signed-off-by: itay elenzweig <[email protected]>
@itayx
controller: tasks: dymanic channel selection task intro
9194e0f 
Intruduction of the dymanic channel selection task.
The task is used to control the flow of the DCS feature.
Add wait for event method.
Add FSM stubs & event handling stubs.

Signed-off-by: itay elenzweig <[email protected]>
@itayx
controller: DCS task: FSM
eb1cfa1 
Implement the FSM stubs in the task.

Signed-off-by: itay elenzweig <[email protected]>
@itayx
controller: DCS task: Events
12c62d3 
Implement event handling in the task.
Implement event timeout in the task.

Signed-off-by: itay elenzweig <[email protected]>
@itayx
controller: DCS task: Node & DB
0cc5c42 
Add database support for the DCS task (set/get id).
Add Node entry for the DCS task ID.

Signed-off-by: itay elenzweig <[email protected]>
@kantera800 kantera800 force-pushed the feature/port-dynamic-channel-selection-from-rdkb-task branch from 5cc493c to 0cc5c42 Compare January 20, 2020 13:03
@kantera800 kantera800 merged commit f2b6907 into master Jan 20, 2020
@kantera800 kantera800 deleted the feature/port-dynamic-channel-selection-from-rdkb-task branch January 20, 2020 14:40
@tomereli tomereli mentioned this pull request Jan 26, 2020
Closed
1 task
@itayx itayx mentioned this pull request Apr 28, 2020
Merged
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kantera800 kantera800 kantera800 left review comments

@tomereli tomereli tomereli approved these changes

@vitalybu vitalybu vitalybu approved these changes

@arnout arnout Awaiting requested review from arnout arnout is a code owner

@morantr morantr Awaiting requested review from morantr morantr is a code owner

Assignees

@itayx itayx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@itayx @kantera800 @arnout @vitalybu @tomereli