Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Update the common project with changes for supporting Turris Omnia and RDKB platforms #466

Merged
merged 12 commits into from
Nov 10, 2019
Merged

Update the common project with changes for supporting Turris Omnia and RDKB platforms #466

merged 12 commits into from
Nov 10, 2019

Conversation

vitalybu
Copy link
Collaborator

@vitalybu vitalybu commented Nov 4, 2019

No description provided.

@morantr morantr self-requested a review November 5, 2019 13:31
@morantr morantr force-pushed the feature/common-add-turris-omnia-rdkb-support branch from 7152958 to 048ae2d Compare November 5, 2019 13:35
tomereli
tomereli suggested changes Nov 5, 2019
View reviewed changes
common/CMakeLists.txt Show resolved Hide resolved
tomereli
tomereli reviewed Nov 5, 2019
View reviewed changes
common/beerocks/bwl/nl80211/ap_wlan_hal_nl80211.cpp
return true;
}

std::string ap_wlan_hal_nl80211::get_radio_driver_version() { return "nl80211"; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also include a TODO which will eventually call the driver NL to get the version? This is assuming there is such an NL.

arnout
arnout suggested changes Nov 6, 2019
View reviewed changes
Copy link
Collaborator

@arnout arnout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed up to " common: bwl (common): add new interface functions ", stopping here to get the comments out.

common/CMakeLists.txt Outdated Show resolved Hide resolved
common/CMakeLists.txt Show resolved Hide resolved
common/CMakeLists.txt Outdated Show resolved Hide resolved
common/CMakeLists.txt Show resolved Hide resolved
common/beerocks/scripts/prplmesh_utils.sh.in Show resolved Hide resolved
common/beerocks/scripts/prplmesh_utils.sh.in Outdated Show resolved Hide resolved
common/beerocks/bcl/include/beerocks/bcl/beerocks_defines.h Outdated Show resolved Hide resolved
common/beerocks/bwl/common/ap_wlan_hal.h
virtual bool disable() = 0;

/*!
* Set start_disabled flag
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a better documentation. Based on this explanation, I wouldn't be able to implement the function and wouldn't know when to call it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be understood from the context.
There is a flag called "start_disabled" which this function is set on a specific vap_id. Also, it is possible to peek on the dwpal implementation to see how it implements it.

This is must be a new function since I don't recall having it in bwl, as well I didn't find any call to it on ap_manager/monitor.

@kantera800 can you add something about this function?

common/beerocks/bwl/common/ap_wlan_hal.h Show resolved Hide resolved
common/beerocks/bwl/common/ap_wlan_hal.h Show resolved Hide resolved
arnout
arnout suggested changes Nov 6, 2019
View reviewed changes
Copy link
Collaborator

@arnout arnout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only. I actually do have major comments as well, but those should be handled as separate tasks so I won't post them here.

common/beerocks/bwl/CMakeLists.txt Show resolved Hide resolved
common/beerocks/bwl/CMakeLists.txt Show resolved Hide resolved
common/beerocks/bwl/CMakeLists.txt Show resolved Hide resolved
common/beerocks/bwl/CMakeLists.txt Show resolved Hide resolved
common/beerocks/bwl/CMakeLists.txt Show resolved Hide resolved
common/beerocks/bwl/CMakeLists.txt Show resolved Hide resolved
@morantr morantr requested review from tomereli and arnout November 7, 2019 10:36
@morantr morantr force-pushed the feature/common-add-turris-omnia-rdkb-support branch 3 times, most recently from 56c93c8 to acae334 Compare November 7, 2019 16:10
@morantr morantr force-pushed the feature/common-add-turris-omnia-rdkb-support branch from acae334 to 1dd0404 Compare November 10, 2019 15:02
@vitalybu @morantr
common: enahnce prplmesh_utils.sh script
91e48dc 
Update the prplmesh_utils.sh script with platform specific commands.
For example, "ps -aux" doesn't work on ASH (busybox shell used in OpenWRT),
so a "ps" without arguments is used in the Turris Omnia platform.
Additionally, allow setting different interface names for different platforms.

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
common: bcl: add load_steer_on_vaps configuration
ce2da3f 
Add the "load_steer_on_vaps" configuration parameter.
This parameter contains the list of VAPs that the controller considers for steering decisions.

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
common: bcl: fix fallthrough macro
6108276 
The [[fallthrough]] annotation is supported from GCC 7.x+

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
common: bcl: bugfixes in common utils functions
7234454 
1. stoi() - support converting negative values
2. get_iface_string_from_iface_vap_ids() - return the interface name for the default VAP

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
common: btl: minor cmake formatting
2b4f94f 
Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
common: bwl (common): add new interface functions
a8d014c 
Add new functions to the base interface to better support specific implementations.
Most of the changes were introduced due to functionality requirements of the RDKB platform.

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
common: bwl (dummy): align with base interface changes
a1711c5 
Implement newly added interface functions.

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
common: bwl (dwpal): align with base interface changes
7371a58 
Implement newly added interface functions and align with latest dwpal changes.

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
common: bwl (nl80211): adding new nl80211 bwl implementaion
60db701 
This new BWL implementation supports native hostapd/wpa_supplicant control socket and 80211 netlink messages.
It was originally developed for the Turris Omnia (OpenWRT), but can be used for any unix based platform running hostapd ontop of a nl80211 wlan driver.

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
common: bwl: add cmake turris-omnia support
a48d80c 
Adding support for Turris Omnia paltform to the base BWL cmake.

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
agent: backhaul_manager: adjustments due to bwl interface changes
40c40e6 
Minor code adjustments due to changes in the  BWL interfaces.

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@vitalybu @morantr
agent: ap_manager: adjustments due to bwl interface changes
da8b476 
Minor code adjustments due to changes in the  BWL interfaces.

Signed-off-by: Vitaly Bukhovsky <[email protected]>
@morantr morantr force-pushed the feature/common-add-turris-omnia-rdkb-support branch from 1dd0404 to da8b476 Compare November 10, 2019 15:15
@morantr morantr merged commit 5643e30 into master Nov 10, 2019
@morantr morantr deleted the feature/common-add-turris-omnia-rdkb-support branch November 10, 2019 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomereli tomereli tomereli approved these changes

@arnout arnout arnout approved these changes

@morantr morantr Awaiting requested review from morantr morantr is a code owner

Assignees

@morantr morantr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitalybu @arnout @morantr @tomereli