Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

PPM-338 Move UCI configuration to Agent DB #1590

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

PPM-338 Move UCI configuration to Agent DB #1590

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1ed9087
agent: Move front radio configuration to AgentDB
orenvor Aug 4, 2020
198dd29
agent: Move back radio configuration to AgentDB
orenvor Aug 4, 2020
b940541
agent: Move mem_only_psk configuration to AgentDB
orenvor Aug 5, 2020
fa19acb
agent: Move backhaul_max_vaps configuration to AgentDB
orenvor Aug 6, 2020
bd04912
agent: Move backhaul_network_enabled configuration to AgentDB
orenvor Aug 6, 2020
6d15f7e
agent: Move backhaul_preferred_radio_band configuration to AgentDB
orenvor Aug 6, 2020
6af1e0b
agent: Move operating_mode configuration to AgentDB
orenvor Aug 6, 2020
e59af3a
agent: Move management_mode configuration to AgentDB
orenvor Aug 6, 2020
84178c6
agent: Move certification_mode configuration to AgentDB
orenvor Aug 6, 2020
8d7e394
agent: Move stop_on_failure_attempts configuration to AgentDB
orenvor Aug 6, 2020
b13191f
agent: Move client_band_steering_enabled configuration to AgentDB
orenvor Aug 6, 2020
d6d17b4
agent: Move client_optimal_path_roaming_enabled configuration to AgentDB
orenvor Aug 6, 2020
f166c0a
agent: Move dfs_reentry_enabled configuration to AgentDB
orenvor Aug 6, 2020
ced7c3d
agent: Move client_optimal_path_prefer_signal_strength to AgentDB
orenvor Aug 6, 2020
1c890a3
agent: Move client_11k_roaming_enabled configuration to AgentDB
orenvor Aug 6, 2020
d672a81
agent: Move load_balancing_enabled configuration to AgentDB
orenvor Aug 6, 2020
9565fce
agent: Move service_fairness_enabled configuration to AgentDB
orenvor Aug 6, 2020
b9541a9
agent: Move rdkb_extensions_enabled configuration to AgentDB
orenvor Aug 6, 2020
5477bb5
agent: remove unused onboarding configuration
orenvor Aug 10, 2020
e3efdfb
tlvf: beerocks_message::sPlatformSettings remove unused settings
orenvor Aug 9, 2020
c666a11
agent: Remove "platform_settings" local variable from son_slave_thread
orenvor Aug 11, 2020
2831a7d
agent: Move wlan_settings configuration to AgentDB
orenvor Aug 11, 2020
cb51ce9
fixup! agent: Move wlan_settings configuration to AgentDB
orenvor Aug 12, 2020
9c450e9
tlvf: PLATFORM_SON_SLAVE_REGISTER_RESPONSE remove unused fields
orenvor Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions agent/src/beerocks/slave/agent_db.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ class AgentDB {
uint8_t mem_only_psk;
uint8_t backhaul_max_vaps;
uint8_t backhaul_network_enabled;
orenvor marked this conversation as resolved.
Show resolved Hide resolved
uint8_t backhaul_preferred_radio_band;
orenvor marked this conversation as resolved.
Show resolved Hide resolved
} back_radio;

bool local_gw;
Expand Down
4 changes: 2 additions & 2 deletions agent/src/beerocks/slave/platform_manager/platform_manager_thread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ static bool fill_platform_settings(
db->device_conf.back_radio.backhaul_max_vaps = uint8_t(platform_common_conf.backhaul_max_vaps);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
db->device_conf.back_radio.backhaul_max_vaps = uint8_t(platform_common_conf.backhaul_max_vaps);
db->device_conf.back_radio.backhaul_max_vaps = static_cast<uint8_t>(platform_common_conf.backhaul_max_vaps);

This PR seems like a good opportunity to replace all these C style casts with the preferred C++ style casts

db->device_conf.back_radio.backhaul_network_enabled =
uint8_t(platform_common_conf.backhaul_network_enabled);
msg->platform_settings().backhaul_preferred_radio_band =
db->device_conf.back_radio.backhaul_preferred_radio_band =
uint8_t(bpl_band_to_freq_type(platform_common_conf.backhaul_preferred_radio_band));

msg->platform_settings().load_balancing_enabled = 0; // for v1.3 TODO read from CAL DB
Expand All @@ -231,7 +231,7 @@ static bool fill_platform_settings(
LOG(DEBUG) << "local_controller: " << db->device_conf.local_controller;
LOG(DEBUG) << "dfs_reentry_enabled: " << (unsigned)msg->platform_settings().dfs_reentry_enabled;
LOG(DEBUG) << "backhaul_preferred_radio_band: "
<< (unsigned)msg->platform_settings().backhaul_preferred_radio_band;
<< (unsigned)db->device_conf.back_radio.backhaul_preferred_radio_band;
orenvor marked this conversation as resolved.
Show resolved Hide resolved
LOG(DEBUG) << "rdkb_extensions: " << (unsigned)msg->platform_settings().rdkb_extensions_enabled;

return true;
Expand Down
2 changes: 1 addition & 1 deletion agent/src/beerocks/slave/son_slave_thread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3114,7 +3114,7 @@ bool slave_thread::slave_fsm(bool &call_slave_select)
platform_to_bwl_security(db->device_conf.back_radio.security_type));
bh_enable->mem_only_psk() = db->device_conf.back_radio.mem_only_psk;
bh_enable->backhaul_preferred_radio_band() =
platform_settings.backhaul_preferred_radio_band;
db->device_conf.back_radio.backhaul_preferred_radio_band;

string_utils::copy_string(bh_enable->wire_iface(message::IFACE_NAME_LENGTH),
db->ethernet.iface_name.c_str(), message::IFACE_NAME_LENGTH);
Expand Down