This repository has been archived by the owner on Sep 7, 2020. It is now read-only.
agent: backhaul_manager: get_media_type(): return true on success #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_media_type() function sets result to false by default. In the IEEE_802_11, it wasn't set to true in the success case. This leads to bug #1097. Set result to true before breaking out of the loop. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
arnout
force-pushed
the
bugfix/1097-no-topology-response
branch
from
58b1572 to
851378f
Compare
tomereli
approved these changes
Apr 7, 2020
| @@ -3439,7 +3439,7 @@ bool backhaul_manager::get_media_type(const std::string &interface_name, | |||
| if ((std::get<0>(tuple) == radio_info.frequency_band) && | |||
| (std::get<1>(tuple) == radio_info.max_bandwidth)) { | |||
| media_type = std::get<2>(tuple); | |||
|
|
|||
| result = true; | |||
There was a problem hiding this comment.
Why can't we just return true in these cases?
There was a problem hiding this comment.
It's the multiple exit points vs. single exit point discussion, which I'm not sure we put to a vote.
rmelotte
approved these changes
Apr 7, 2020
|
Mario did the same fix in parallel and his version is slightly better, so I'm closing this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_media_type() function sets result to false by default. In the
IEEE_802_11, it wasn't set to true in the success case.
Set result to true before breaking out of the loop.
Fixes: #1097