Feature/channel pool validation #1093
Conversation
itayx
force-pushed
the
feature/channel-pool-validation
branch
3 times, most recently
from
6e79c90 to
e584bbb
Compare
itayx
force-pushed
the
feature/channel-pool-validation
branch
3 times, most recently
from
474ee96 to
233395e
Compare
itayx
force-pushed
the
feature/channel-pool-validation
branch
from
233395e to
891bff6
Compare
itayx
requested review from
arnout,
morantr,
rmelotte,
tomereli and
vitalybu
as code owners
| return supported_channel.channel == channel; | ||
| }); | ||
| if (found_channel == supported_channels.end()) { | ||
| LOG(ERROR) << "channel #" << int(channel) << " is not supported"; |
There was a problem hiding this comment.
To me it's a bit weird that a function called is_channel_scan_pool_supported logs something (especially an error) if a channel is not supported. Maybe it would be best to leave that to the caller (or to change the level to INFO or DEBUG).
Aren't there any case where you would want to call is_channel_scan_pool_supported without logging an error?
(nitpick)
There was a problem hiding this comment.
I completely understand
And I think I'll change it to INFO
But I still want the log, that way there is a log of which sent channel isn't supported
Since the function doesn't return the unsupported channel, the only way to know which is via the log
|
approved , but don't merge it yet. |
itayx
force-pushed
the
feature/channel-pool-validation
branch
from
891bff6 to
46f87b6
Compare
In the set_channel_scan_pool function to validate the channel pool, we run a check to see if the channel is supported. Currently the supported channel list is a static list. Add is_channel_scan_pool_supported function to the DB. Use the is_supported function to validate channel pool. Signed-off-by: itay elenzweig <[email protected]>
itayx
force-pushed
the
feature/channel-pool-validation
branch
from
46f87b6 to
127f98b
Compare
itayx
added
ready for merge
Currently the DCS's set_channel_scan_pool uses a static list of supported channels for verifications to see if the channels provided in the channel pool are supported.
The DB has a list known as hostap_supported_channels, this is filled with channels provided by the basic radio capabilities
The DCS's set_channel_scan_pool need to validate it's channel pool against this supported channels list