This repository has been archived by the owner on Sep 7, 2020. It is now read-only.
[BUG] bwl: missing channels when using nl80211_client::get_radio_info #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tomereli
approved these changes
Apr 5, 2020
itayx
approved these changes
Apr 5, 2020
The radio_info struct returned by get_radio_info was not correct: - The resulting array of supported channels contained a few incorrect values. - The channel list contains channels with irregular bandwidths (channel 36 with bandwidth 160 etc.). - And some of the channels that should be supported were not stored in the channel list. - DFS channels are not present even though they are supported. To fix the problem, NL80211_CMD_GET_WIPHY command has to be executed with NLM_F_DUMP flag and NL80211_ATTR_SPLIT_WIPHY_DUMP flag attribute has to be added to request message. This is the way `iw` command line tool works. After these changes, response is returned as a series of multipart messages. Signed-off-by: Mario Maz <[email protected]>
Message handling function returns bool. It can return false, but that does not necessarily mean that an error has occurred, specially when message received is one of the parts in a series of multi part messages. Anyway, there couldn't be much we can do in send_receive_msg on error. Therefore, there is no need to check return value and log an error if handling function returns false. It is the responsibility of the handling function to deal with and log such errors. Change type of msg_handle function from bool to void. Remove error log messages when it is not actually an error condition. Signed-off-by: Mario Maz <[email protected]>
mariomaz
force-pushed
the
bugfix/nl80211_client_impl-get_radio_info
branch
from
daa02ff to
29ecf8c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1046