Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement getentropy using wasi preview 1 #177

Closed
wants to merge 2 commits into from

Conversation

martijneken
Copy link
Contributor

Fixes #175

Short term fix for: emscripten-core/emscripten#22782

Signed-off-by: Martijn Stevenson <[email protected]>
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how fast do you need this, but shouldn't this be fixed in Emscripten instead?

@martijneken
Copy link
Contributor Author

martijneken commented Oct 28, 2024

I'm not sure how fast do you need this, but shouldn't this be fixed in Emscripten instead?

Yes, this is just patching CppSdk in the meantime, we can remove it with the next emsdk update. I'd like to get absl support in good shape sooner for a launch with absl code samples.

@martijneken martijneken reopened this Oct 28, 2024
@martijneken
Copy link
Contributor Author

Sigh. Accidentally closed this, looks like I need a new PR.

@martijneken martijneken deleted the patch-getentropy branch October 29, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Abseil/RE2 in Bazel + Docker
2 participants