Fix dupe linker opt, add TODO for Docker builds

Signed-off-by: Martijn Stevenson <[email protected]>
proxy-wasm · Oct 10, 2024 · d505642 · d505642
1 parent 668c5f3
commit d505642
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/bazel/defs.bzl b/bazel/defs.bzl
@@ -95,7 +95,6 @@ def proxy_wasm_cc_binary(
         linkopts = linkopts + [
             "--no-entry",
             "--js-library=$(location @proxy_wasm_cpp_sdk//:proxy_wasm_intrinsics_js)",
-            "-sSTANDALONE_WASM",
             "-sEXPORTED_FUNCTIONS=_malloc",
         ],
         tags = tags + [

diff --git a/sdk_container.sh b/sdk_container.sh
@@ -81,6 +81,7 @@ rm -rf protobuf-wasm
 git clone https://github.com/abseil/abseil-cpp
 cd abseil-cpp
 git checkout 4447c7562e3bc702ade25105912dce503f0c4010 -b lts20240722 # Abseil LTS release 20240722.0
+# TODO -DSTANDALONE_WASM -sSTANDALONE_WASM ?
 emcmake cmake -DCMAKE_CXX_STANDARD=17 "."
 emmake make -j $JOBS
 cd