Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): AI Search service check not publicly accesible #5846

Conversation

StylusFrost
Copy link
Contributor

@StylusFrost StylusFrost commented Nov 20, 2024

Context

All resources related to AI projects are also subject to audits. Azure AI Search is the primary retrieval system when building RAG-based applications on Azure, with native LLM integrations between Azure OpenAI Service and Azure Machine Learning.

Description

This PR adds the not publicly accessible check for the Azure AI Search service as well as the base artifacts for other AI Search service checks

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

feat(azure): Search service
test(azure): Search service azure - service tests
test(azure): Search service check not publicly accesible tests
docs: Search service check not publicly accesible metadata
@StylusFrost StylusFrost requested review from a team as code owners November 20, 2024 20:23
@github-actions github-actions bot added the provider/azure Issues/PRs related with the Azure provider label Nov 20, 2024
@jfagoagas jfagoagas self-assigned this Nov 20, 2024
@puchy22 puchy22 self-assigned this Nov 21, 2024
@jfagoagas jfagoagas changed the title feat(azure): Ai Search service check not publicly accesible feat(azure): AI Search service check not publicly accesible Nov 21, 2024
StylusFrost and others added 11 commits November 21, 2024 12:09
…licly_accessible/search_service_not_publicly_accessible.metadata.json

Co-authored-by: Rubén De la Torre Vico <[email protected]>
…licly_accessible/search_service_not_publicly_accessible.metadata.json

Co-authored-by: Rubén De la Torre Vico <[email protected]>
…licly_accessible/search_service_not_publicly_accessible.metadata.json

Co-authored-by: Rubén De la Torre Vico <[email protected]>
…licly_accessible/search_service_not_publicly_accessible.metadata.json

Co-authored-by: Rubén De la Torre Vico <[email protected]>
…licly_accessible/search_service_not_publicly_accessible.py

Co-authored-by: Rubén De la Torre Vico <[email protected]>
…licly_accessible/search_service_not_publicly_accessible.metadata.json

Co-authored-by: Rubén De la Torre Vico <[email protected]>
Co-authored-by: Rubén De la Torre Vico <[email protected]>
feat: using a dict to store all the services
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.89%. Comparing base (26a9748) to head (7f7739c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...viders/azure/services/aisearch/aisearch_service.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5846      +/-   ##
==========================================
+ Coverage   89.84%   89.89%   +0.05%     
==========================================
  Files        1139     1142       +3     
  Lines       35483    35532      +49     
==========================================
+ Hits        31878    31940      +62     
+ Misses       3605     3592      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

puchy22
puchy22 previously approved these changes Nov 22, 2024
Copy link
Member

@puchy22 puchy22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! 💯

Copy link
Member

@puchy22 puchy22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrCloudSec MrCloudSec merged commit fee0bf3 into prowler-cloud:master Nov 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants