-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compliance): add ENSRD2022 for Azure and GCP #5746
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5746 +/- ##
==========================================
- Coverage 89.89% 89.88% -0.01%
==========================================
Files 1128 1135 +7
Lines 35182 35415 +233
==========================================
+ Hits 31628 31834 +206
- Misses 3554 3581 +27 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed IRL, thanks for this great amount of work 🚀
Description
This pull request introduces several changes to enhance the compliance reporting capabilities for Azure and GCP in the
prowler
project. The most significant changes include the addition of new compliance frameworks for Azure and GCP, updates to theprowler
main script to handle these new frameworks, and the creation of corresponding test cases.Thanks @normanecg for the GCP and Azure ENS json ❤️
Compliance Frameworks Enhancements:
prowler/__main__.py
: Added support for Azure and GCP ENS compliance frameworks by importingAzureENS
andGCPENS
classes and updating theprowler
function to handle these new compliance types. [1] [2] [3]prowler/lib/outputs/compliance/ens/ens_azure.py
: Introduced theAzureENS
class to represent Azure ENS compliance output, including methods to transform findings into Azure ENS compliance format.prowler/lib/outputs/compliance/ens/ens_gcp.py
: Introduced theGCPENS
class to represent GCP ENS compliance output, including methods to transform findings into GCP ENS compliance format.Codebase Updates:
prowler/lib/outputs/compliance/ens/ens.py
: Modified theget_ens_table
function to generalize the ENS compliance framework handling, removing the specific check for AWS.prowler/lib/outputs/compliance/ens/models.py
: AddedAzureENSModel
andGCPENSModel
classes to generate findings' output in CSV ENS format for Azure and GCP, respectively.Documentation and Testing:
README.md
: Updated the compliance frameworks section to reflect the new compliance checks available for Azure and GCP.tests/lib/outputs/compliance/ens/ens_azure_test.py
: Added test cases for theAzureENS
class to ensure the correct transformation of findings and proper CSV output generation.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.