Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compliance): add ENSRD2022 for Azure and GCP #5746

Merged
merged 12 commits into from
Nov 21, 2024

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Nov 13, 2024

Description

This pull request introduces several changes to enhance the compliance reporting capabilities for Azure and GCP in the prowler project. The most significant changes include the addition of new compliance frameworks for Azure and GCP, updates to the prowler main script to handle these new frameworks, and the creation of corresponding test cases.

Thanks @normanecg for the GCP and Azure ENS json ❤️

Compliance Frameworks Enhancements:

Codebase Updates:

Documentation and Testing:

  • README.md: Updated the compliance frameworks section to reflect the new compliance checks available for Azure and GCP.
  • tests/lib/outputs/compliance/ens/ens_azure_test.py: Added test cases for the AzureENS class to ensure the correct transformation of findings and proper CSV output generation.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot marked this pull request as ready for review November 15, 2024 11:50
@pedrooot pedrooot requested review from a team as code owners November 15, 2024 11:50
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 86.31579% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.88%. Comparing base (f3cfaca) to head (b11dbad).
Report is 60 commits behind head on master.

Files with missing lines Patch % Lines
prowler/__main__.py 0.00% 12 Missing ⚠️
prowler/lib/outputs/compliance/ens/ens.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5746      +/-   ##
==========================================
- Coverage   89.89%   89.88%   -0.01%     
==========================================
  Files        1128     1135       +7     
  Lines       35182    35415     +233     
==========================================
+ Hits        31628    31834     +206     
- Misses       3554     3581      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@github-actions github-actions bot added the compliance Issues/PRs related with the Compliance Frameworks label Nov 20, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed IRL, thanks for this great amount of work 🚀

@jfagoagas jfagoagas merged commit 2e20d52 into master Nov 21, 2024
9 of 11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-5342-add-ens-for-azure-and-gcp branch November 21, 2024 08:36
@jfagoagas jfagoagas changed the title feat(compliance): add ens for azure and gcp feat(compliance): add ENSRD2022 for Azure and GCP Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compliance Issues/PRs related with the Compliance Frameworks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants