Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aws): improve docstrings #5714

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

pedrooot
Copy link
Member

Description

This pull request introduces comprehensive docstrings to the AwsProvider class and its methods in the prowler/providers/aws/aws_provider.py file. These changes aim to enhance code readability and provide clear documentation for future developers.

Enhancements to Documentation:

  • Class-level docstring:

    • Added a detailed description of the AwsProvider class, including its responsibilities and attributes.
  • Method-level docstrings:

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners November 11, 2024 12:43
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.87%. Comparing base (344d541) to head (6c48d25).
Report is 49 commits behind head on master.

Files with missing lines Patch % Lines
prowler/providers/aws/aws_provider.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5714      +/-   ##
==========================================
- Coverage   89.94%   89.87%   -0.07%     
==========================================
  Files        1124     1132       +8     
  Lines       34815    35275     +460     
==========================================
+ Hits        31313    31704     +391     
- Misses       3502     3571      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

prowler/providers/aws/aws_provider.py Outdated Show resolved Hide resolved
@jfagoagas jfagoagas self-requested a review November 13, 2024 14:25
@jfagoagas jfagoagas changed the title feat(aws): improve docstrings docs(aws): improve docstrings Nov 18, 2024
prowler/providers/aws/aws_provider.py Outdated Show resolved Hide resolved
@jfagoagas jfagoagas self-requested a review November 18, 2024 10:20
@jfagoagas jfagoagas merged commit 5d7c8d9 into master Nov 18, 2024
9 of 11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-5132-aws-document-provider-authentication branch November 18, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants