Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoscaling): add new check autoscaling_group_launch_configuration_no_public_ip #5359

Conversation

danibarranqueroo
Copy link
Member

Context

This check verifies whether the launch configuration associated with an Auto Scaling group assigns a public IP address to its instances. The check fails if the launch configuration assigns a public IP address.

There was a similar check on ec2 that verifies this using launch template instead of launch configuration, I've followed what this SH control says but if it's worth to check also launch templates as it's explained here for example, please ping me and we can discuss if this new feature should be added here or as a new check.

Description

Added new check autoscaling_group_launch_configuration_no_public_ip with its unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners October 10, 2024 11:27
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (4181ca5) to head (6fe9855).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5359      +/-   ##
==========================================
- Coverage   89.38%   89.37%   -0.01%     
==========================================
  Files        1018     1019       +1     
  Lines       31278    31299      +21     
==========================================
+ Hits        27959    27975      +16     
- Misses       3319     3324       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit e0ed891 into master Oct 14, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4293-add-new-auto-scaling-check-to-verify-ec-2-instances-do-not-have-public-i-ps branch October 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants