Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iam): add exception for public policy in EKS service #4759

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Aug 16, 2024

Context

Fix #4745

Description

Update function is_policy_public adding exception for EKS service.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners August 16, 2024 07:59
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (78b518e) to head (597952d).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4759      +/-   ##
==========================================
+ Coverage   89.88%   89.90%   +0.01%     
==========================================
  Files        1132     1132              
  Lines       35275    35275              
==========================================
+ Hits        31707    31714       +7     
+ Misses       3568     3561       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should improve the logic of the check to avoid false negatives, like in #4714 too.

@MrCloudSec MrCloudSec added the no-merge Please, DO NOT MERGE this PR. label Aug 20, 2024
@puchy22 puchy22 marked this pull request as draft September 25, 2024 14:07
@puchy22 puchy22 changed the title chore(iam): Add note for EKS not repairable case chore(iam): add note for EKS not repairable case Oct 3, 2024
…s-service-confused-deputy-prevention-metadata-for-an-eks-case-that-cannot-be-repaired
@puchy22 puchy22 marked this pull request as ready for review November 18, 2024 08:59
@puchy22 puchy22 changed the title chore(iam): add note for EKS not repairable case chore(iam): add exception for public policy in EKS service Nov 18, 2024
@MrCloudSec MrCloudSec self-requested a review November 19, 2024 13:42
@MrCloudSec MrCloudSec removed the no-merge Please, DO NOT MERGE this PR. label Nov 19, 2024
@MrCloudSec MrCloudSec merged commit e33b081 into master Nov 19, 2024
12 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4592-add-a-note-in-the-iam-role-cross-service-confused-deputy-prevention-metadata-for-an-eks-case-that-cannot-be-repaired branch November 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confused Deputy Attack finding for AWS EKS service
2 participants