-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(iam): add exception for public policy in EKS service #4759
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4759 +/- ##
==========================================
+ Coverage 89.88% 89.90% +0.01%
==========================================
Files 1132 1132
Lines 35275 35275
==========================================
+ Hits 31707 31714 +7
+ Misses 3568 3561 -7 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should improve the logic of the check to avoid false negatives, like in #4714 too.
…s-service-confused-deputy-prevention-metadata-for-an-eks-case-that-cannot-be-repaired
Context
Fix #4745
Description
Update function
is_policy_public
adding exception for EKS service.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.