Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU-86b1g1mye_SRU2024_Generar-un-enum-de-FieldNames-para-validar-que-e… #194

Merged
merged 3 commits into from
Sep 30, 2024
Merged

CU-86b1g1mye_SRU2024_Generar-un-enum-de-FieldNames-para-validar-que-e… #194

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a09803
CU-86b1g1mye_SRU2024_Generar-un-enum-de-FieldNames-para-validar-que-e…
ptorres-prowide Aug 22, 2024
b6c99c0
CU-86b1g1mye_SRU2024_Generar-un-enum-de-FieldNames-para-validar-que-e…
ptorres-prowide Sep 5, 2024
8072676
Merge branch 'SRU2024' into CU-86b1g1mye_SRU2024_Generar-un-enum-de-F…
zubri Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Prowide Core - CHANGELOG

#### 9.5.2 - SNAPSHOT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust the heading level for version entry.

The heading level for version 9.5.2 should be consistent with the rest of the document. Change it to level 2.

Apply this diff to fix the heading level:

-#### 9.5.2 - SNAPSHOT
+## 9.5.2 - SNAPSHOT
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#### 9.5.2 - SNAPSHOT
## 9.5.2 - SNAPSHOT
Tools
Markdownlint

3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)

3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)

* Added new FieldEnum with all the available field names
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Adjust formatting for consistency and readability.

Please make the following changes to improve the formatting of the changelog entry:

  1. Change the heading level from h4 to h2 for consistency with other version entries.
  2. Add a blank line before the heading.
  3. Remove the indentation for the bullet point.

Apply this diff to fix the formatting:

+
-#### 9.5.2 - SNAPSHOT
-  * Added new FieldEnum with all the available field names
+## 9.5.2 - SNAPSHOT
+* Added new FieldEnum with all the available field names
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#### 9.5.2 - SNAPSHOT
* Added new FieldEnum with all the available field names
## 9.5.2 - SNAPSHOT
* Added new FieldEnum with all the available field names
🧰 Tools
🪛 Markdownlint

3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)

4-4: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)

3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)

4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


#### 9.5.1 - June 2024
* (PW-1913) Added IBAN validation for Egypt local account structure
* Restore deprecated method in MT210 class
Expand Down
Loading
Loading