Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRU2022 v10 #161

Closed
wants to merge 18 commits into from
Closed

SRU2022 v10 #161

wants to merge 18 commits into from

Conversation

zubri
Copy link
Member

@zubri zubri commented May 9, 2023

This PR contains the migration to Java 11 and Jakarta EE 10 for the current SRU2022.

In terms of library releases, this branch develops and maintains all prowide-core-SRU2022-10.0.x versions.

More info at https://dev.prowidesoftware.com/SRU2022/release-notes/

zubri and others added 5 commits May 8, 2023 19:34
…va 11 (#153)

* Migration to Java 11
* Migration to Jakarta EE 10
---------

Co-authored-by: Nicolas Filotto <[email protected]>
Co-authored-by: ptorres-prowide <[email protected]>
Co-authored-by: ptorres-prowide <[email protected]>
@zubri
Copy link
Member Author

zubri commented May 10, 2023

com.prowidesoftware:prowide-core:SRU2022-10.0.0-RC1 released

@zubri
Copy link
Member Author

zubri commented May 10, 2023

RC1 has been released

https://central.sonatype.com/artifact/com.prowidesoftware/pw-swift-core/SRU2022-10.0.0-RC1

Including:

  • Migration to Java 11
  • Migration to Jakarta EE 10

@zubri
Copy link
Member Author

zubri commented May 30, 2023

Release done

https://central.sonatype.com/artifact/com.prowidesoftware/pw-swift-core/SRU2022-10.0.0

@spannm
Copy link
Collaborator

spannm commented May 30, 2023

Nice! 👍🏻

@zubri
Copy link
Member Author

zubri commented Jun 6, 2023

These classes are still using old javax xml bind:

https://github.com/prowide/prowide-core/blob/SRU2022_v10/src/main/java/com/prowidesoftware/swift/utils/SafeXmlUtils.java#L24-L32 https://github.com/prowide/prowide-core/blob/SRU2022_v10/src/main/java/com/prowidesoftware/swift/io/parser/XMLParser.java#L32 https://github.com/prowide/prowide-core/blob/SRU2022_v10/src/test/java/com/prowidesoftware/swift/io/parser/XMLParserTest.java#L35

The classes you refer to are part of the Java SE platform and are not specific to the javax.xml.bind package. They are still available in Java 11 and later versions and do not need to be replaced with Jakarta equivalents.

@ratoaq2
Copy link

ratoaq2 commented Jun 7, 2023

Sorry, you're completely correct. I overlooked that

@@ -47,8 +47,7 @@
@Entity(name = "mt")
@DiscriminatorValue("mt")
public class MtSwiftMessage extends AbstractSwiftMessage {
private static final transient java.util.logging.Logger log =
java.util.logging.Logger.getLogger(MtSwiftMessage.class.getName());
private static final transient java.util.logging.Logger log = java.util.logging.Logger.getLogger(MtSwiftMessage.class.getName());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4% of developers fix this issue

UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.


Suggested change
private static final transient java.util.logging.Logger log = java.util.logging.Logger.getLogger(MtSwiftMessage.class.getName());
private static final transient Logger log = Logger.getLogger(MtSwiftMessage.class.getName());

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@@ -47,8 +47,7 @@
@Entity(name = "mt")
@DiscriminatorValue("mt")
public class MtSwiftMessage extends AbstractSwiftMessage {
private static final transient java.util.logging.Logger log =
java.util.logging.Logger.getLogger(MtSwiftMessage.class.getName());
private static final transient java.util.logging.Logger log = java.util.logging.Logger.getLogger(MtSwiftMessage.class.getName());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4% of developers fix this issue

UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.


Suggested change
private static final transient java.util.logging.Logger log = java.util.logging.Logger.getLogger(MtSwiftMessage.class.getName());
private static final transient Logger log = Logger.getLogger(MtSwiftMessage.class.getName());

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@zubri
Copy link
Member Author

zubri commented Nov 21, 2023

This PR has been replaced by the SRU2023 v10 containing also the migration to Jakarta and Java 11, but with the current SRU2023 standard

@zubri zubri closed this Nov 21, 2023
@zubri zubri deleted the SRU2022_v10 branch November 21, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants